2022-08-28 19:58:17

by Akhil P Oommen

[permalink] [raw]
Subject: [PATCH v5 0/6] clk/qcom: Support gdsc collapse polling using 'reset' interface


Some clients like adreno gpu driver would like to ensure that its gdsc
is collapsed at hardware during a gpu reset sequence. This is because it
has a votable gdsc which could be ON due to a vote from another subsystem
like tz, hyp etc or due to an internal hardware signal. To allow
this, gpucc driver can expose an interface to the client driver using
reset framework. Using this the client driver can trigger a polling within
the gdsc driver.

This series is rebased on top of linus's master branch.

Related discussion: https://patchwork.freedesktop.org/patch/493144/

Changes in v5:
- Nit: Remove a duplicate blank line (Krzysztof)

Changes in v4:
- Update gpu dt-binding schema
- Typo fix in commit text

Changes in v3:
- Use pointer to const for "struct qcom_reset_ops" in qcom_reset_map (Krzysztof)

Changes in v2:
- Return error when a particular custom reset op is not implemented. (Dmitry)

Akhil P Oommen (6):
dt-bindings: clk: qcom: Support gpu cx gdsc reset
clk: qcom: Allow custom reset ops
clk: qcom: gdsc: Add a reset op to poll gdsc collapse
clk: qcom: gpucc-sc7280: Add cx collapse reset support
dt-bindings: drm/msm/gpu: Add optional resets
arm64: dts: qcom: sc7280: Add Reset support for gpu

.../devicetree/bindings/display/msm/gpu.yaml | 6 +++++
arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
drivers/clk/qcom/gdsc.c | 23 ++++++++++++++----
drivers/clk/qcom/gdsc.h | 7 ++++++
drivers/clk/qcom/gpucc-sc7280.c | 10 ++++++++
drivers/clk/qcom/reset.c | 27 ++++++++++++++++++++++
drivers/clk/qcom/reset.h | 8 +++++++
include/dt-bindings/clock/qcom,gpucc-sc7280.h | 3 +++
8 files changed, 83 insertions(+), 4 deletions(-)

--
2.7.4


2022-08-29 22:49:33

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v5 0/6] clk/qcom: Support gdsc collapse polling using 'reset' interface

+Philipp

Quoting Akhil P Oommen (2022-08-28 12:21:13)
>
> Some clients like adreno gpu driver would like to ensure that its gdsc
> is collapsed at hardware during a gpu reset sequence. This is because it
> has a votable gdsc which could be ON due to a vote from another subsystem
> like tz, hyp etc or due to an internal hardware signal. To allow
> this, gpucc driver can expose an interface to the client driver using
> reset framework. Using this the client driver can trigger a polling within
> the gdsc driver.

Please include the reset maintainer on reset related patches.

-Stephen

>
> This series is rebased on top of linus's master branch.
>
> Related discussion: https://patchwork.freedesktop.org/patch/493144/
>
> Changes in v5:
> - Nit: Remove a duplicate blank line (Krzysztof)
>
> Changes in v4:
> - Update gpu dt-binding schema
> - Typo fix in commit text
>
> Changes in v3:
> - Use pointer to const for "struct qcom_reset_ops" in qcom_reset_map (Krzysztof)
>
> Changes in v2:
> - Return error when a particular custom reset op is not implemented. (Dmitry)
>
> Akhil P Oommen (6):
> dt-bindings: clk: qcom: Support gpu cx gdsc reset
> clk: qcom: Allow custom reset ops
> clk: qcom: gdsc: Add a reset op to poll gdsc collapse
> clk: qcom: gpucc-sc7280: Add cx collapse reset support
> dt-bindings: drm/msm/gpu: Add optional resets
> arm64: dts: qcom: sc7280: Add Reset support for gpu
>
> .../devicetree/bindings/display/msm/gpu.yaml | 6 +++++
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
> drivers/clk/qcom/gdsc.c | 23 ++++++++++++++----
> drivers/clk/qcom/gdsc.h | 7 ++++++
> drivers/clk/qcom/gpucc-sc7280.c | 10 ++++++++
> drivers/clk/qcom/reset.c | 27 ++++++++++++++++++++++
> drivers/clk/qcom/reset.h | 8 +++++++
> include/dt-bindings/clock/qcom,gpucc-sc7280.h | 3 +++
> 8 files changed, 83 insertions(+), 4 deletions(-)