2022-08-29 05:30:11

by Xinlei Lee (李昕磊)

[permalink] [raw]
Subject: [PATCH] dt-bindings: pwm: Add compatible for Mediatek MT8188

From: xinlei lee <[email protected]>

Base on the branch of Linux-next/master.
Split from series [1].
[1] https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/

Add dt-binding documentation of pwm for MediaTek MT8188 SoC.

Signed-off-by: xinlei lee <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
index 8c4f8bf..0088bc8 100644
--- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -27,6 +27,7 @@ properties:
- items:
- enum:
- mediatek,mt8186-disp-pwm
+ - mediatek,mt8188-disp-pwm
- mediatek,mt8192-disp-pwm
- mediatek,mt8195-disp-pwm
- const: mediatek,mt8183-disp-pwm
--
2.6.4


Subject: Re: [PATCH] dt-bindings: pwm: Add compatible for Mediatek MT8188

Il 29/08/22 05:48, [email protected] ha scritto:
> From: xinlei lee <[email protected]>
>
> Base on the branch of Linux-next/master.
> Split from series [1].
> [1] https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/
>
> Add dt-binding documentation of pwm for MediaTek MT8188 SoC.
>
> Signed-off-by: xinlei lee <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

2022-09-19 08:49:22

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: pwm: Add compatible for Mediatek MT8188

On Mon, Aug 29, 2022 at 11:48:36AM +0800, [email protected] wrote:
> From: xinlei lee <[email protected]>
>
> Base on the branch of Linux-next/master.
> Split from series [1].
> [1] https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/
>
> Add dt-binding documentation of pwm for MediaTek MT8188 SoC.
>
> Signed-off-by: xinlei lee <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>

The change looks fine, the commit log isn't that informative. I'd just
write:

Subject: dt-bindings: pwm/mediatek: Add compatible for Mediatek MT8188

Add dt-binding documentation for PWM found on MediaTek MT8188 SoC.

Signed-off-by: ...

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachments:
(No filename) (942.00 B)
 signature.asc (499.00 B)
 Download all attachments