2022-09-05 06:46:14

by Jiapeng Chong

Subject: [PATCH v2] block/blk-map: Remove set but unused variable 'added'

The variable added is not effectively used in the function, so delete
it.

block/blk-map.c:273:16: warning: variable 'added' set but not used.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2049
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
Changes in v2:
-Remove offs initialization.

block/blk-map.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/blk-map.c b/block/blk-map.c
index 2fbe298d3822..8d1e84b04b4a 100644
--- a/block/blk-map.c
+++ b/block/blk-map.c
@@ -270,7 +270,7 @@ static int bio_map_user_iov(struct request *rq, struct iov_iter *iter,
while (iov_iter_count(iter)) {
struct page **pages, *stack_pages[UIO_FASTIOV];
ssize_t bytes;
- size_t offs, added = 0;
+ size_t offs;
int npages;

if (nr_vecs <= ARRAY_SIZE(stack_pages)) {
@@ -306,7 +306,6 @@ static int bio_map_user_iov(struct request *rq, struct iov_iter *iter,
break;
}

- added += n;
bytes -= n;
offs = 0;
}
--
2.20.1.7.g153144c

2022-09-05 18:45:46

by Jens Axboe

Subject: Re: [PATCH v2] block/blk-map: Remove set but unused variable 'added'

On Mon, 5 Sep 2022 14:32:53 +0800, Jiapeng Chong wrote:
> The variable added is not effectively used in the function, so delete
> it.
>
> block/blk-map.c:273:16: warning: variable 'added' set but not used.
>
>

Applied, thanks!

[1/1] block/blk-map: Remove set but unused variable 'added'
commit: 91e5adda5cf4e3bf21c46eaa2ae7ee2cb6058126

Best regards,
--
Jens Axboe