2022-08-29 13:30:51

by Maxime Ripard

Subject: [PATCH v2 38/41] drm/sun4i: tv: Remove useless destroy function

Our destroy implementation is just calling the generic helper, so let's

just remove our function and directly use the helper.



Signed-off-by: Maxime Ripard <[email protected]>

Reviewed-by: Jernej Skrabec <[email protected]>



diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c

index 52bbba8f19dc..6d7e1d51569a 100644

--- a/drivers/gpu/drm/sun4i/sun4i_tv.c

+++ b/drivers/gpu/drm/sun4i/sun4i_tv.c

@@ -491,15 +491,9 @@ static const struct drm_connector_helper_funcs sun4i_tv_comp_connector_helper_fu

.get_modes = sun4i_tv_comp_get_modes,

};



-static void

-sun4i_tv_comp_connector_destroy(struct drm_connector *connector)

-{

- drm_connector_cleanup(connector);

-}

-

static const struct drm_connector_funcs sun4i_tv_comp_connector_funcs = {

.fill_modes = drm_helper_probe_single_connector_modes,

- .destroy = sun4i_tv_comp_connector_destroy,

+ .destroy = drm_connector_cleanup,

.reset = drm_atomic_helper_connector_reset,

.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,

.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,



--

b4 0.10.0-dev-65ba7

2022-09-07 09:46:45

by Maxime Ripard

Subject: Re: (subset) [PATCH v2 38/41] drm/sun4i: tv: Remove useless destroy function

On Mon, 29 Aug 2022 15:11:52 +0200, Maxime Ripard wrote:
> Our destroy implementation is just calling the generic helper, so let's
> just remove our function and directly use the helper.
>
>

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime