2022-09-09 19:14:57

by Easwar Hariharan

Subject: [PATCH v2 1/2] hv: Use PCI_VENDOR_ID_MICROSOFT for better discoverability

From: Easwar Hariharan <[email protected]>

Signed-off-by: Easwar Hariharan <[email protected]>
---
drivers/hv/vmbus_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 3c833ea..6b77a53 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -39,6 +39,8 @@
#include <clocksource/hyperv_timer.h>
#include "hyperv_vmbus.h"

+#define PCI_VENDOR_ID_MICROSOFT 0x1414
+
struct vmbus_dynid {
struct list_head node;
struct hv_vmbus_device_id id;
@@ -2052,7 +2054,7 @@ struct hv_device *vmbus_device_create(const guid_t *type,
child_device_obj->channel = channel;
guid_copy(&child_device_obj->dev_type, type);
guid_copy(&child_device_obj->dev_instance, instance);
- child_device_obj->vendor_id = 0x1414; /* MSFT vendor ID */
+ child_device_obj->vendor_id = PCI_VENDOR_ID_MICROSOFT;

return child_device_obj;
}
--
1.8.3.1

2022-09-12 15:39:31

by Wei Liu

Subject: Re: [PATCH v2 1/2] hv: Use PCI_VENDOR_ID_MICROSOFT for better discoverability

On Fri, Sep 09, 2022 at 11:50:24AM -0700, Easwar Hariharan wrote:
> From: Easwar Hariharan <[email protected]>
>
> Signed-off-by: Easwar Hariharan <[email protected]>

> ---
> drivers/hv/vmbus_drv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 3c833ea..6b77a53 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -39,6 +39,8 @@
> #include <clocksource/hyperv_timer.h>
> #include "hyperv_vmbus.h"
>
> +#define PCI_VENDOR_ID_MICROSOFT 0x1414
> +

There is a patch in hyperv-fixes that puts this definition to a proper
header. You can wait for that to land and rebase this patch.

In the future when you send out a series, please chain all the patches
to a cover letter.

Thanks,
Wei.

> struct vmbus_dynid {
> struct list_head node;
> struct hv_vmbus_device_id id;
> @@ -2052,7 +2054,7 @@ struct hv_device *vmbus_device_create(const guid_t *type,
> child_device_obj->channel = channel;
> guid_copy(&child_device_obj->dev_type, type);
> guid_copy(&child_device_obj->dev_instance, instance);
> - child_device_obj->vendor_id = 0x1414; /* MSFT vendor ID */
> + child_device_obj->vendor_id = PCI_VENDOR_ID_MICROSOFT;
>
> return child_device_obj;
> }
> --
> 1.8.3.1
>

2022-09-19 19:57:01

by Easwar Hariharan

Subject: Re: [PATCH v2 1/2] hv: Use PCI_VENDOR_ID_MICROSOFT for better discoverability

On Mon, 12 Sep 2022, Wei Liu wrote:

> On Fri, Sep 09, 2022 at 11:50:24AM -0700, Easwar Hariharan wrote:
>> From: Easwar Hariharan <[email protected]>
>>
>> Signed-off-by: Easwar Hariharan <[email protected]>
>
>> ---
>> drivers/hv/vmbus_drv.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
>> index 3c833ea..6b77a53 100644
>> --- a/drivers/hv/vmbus_drv.c
>> +++ b/drivers/hv/vmbus_drv.c
>> @@ -39,6 +39,8 @@
>> #include <clocksource/hyperv_timer.h>
>> #include "hyperv_vmbus.h"
>>
>> +#define PCI_VENDOR_ID_MICROSOFT 0x1414
>> +
>
> There is a patch in hyperv-fixes that puts this definition to a proper
> header. You can wait for that to land and rebase this patch.
>
> In the future when you send out a series, please chain all the patches
> to a cover letter.

Hi Wei,

This patch is already rebased on hyperv/fixes in response to Vitaly's
pointer in this thread:
https://lore.kernel.org/lkml/[email protected]

I'll pull in the pci_ids.h inclusion if that's more acceptable.

Thanks,
Easwar

>> --
>> 1.8.3.1
>>
>