2022-08-19 17:42:14

by Oliver Upton

Subject: [RESEND PATCH] KVM: selftests: Update top-of-file comment in psci_test

Fix the comment to accurately describe the test and recently added
SYSTEM_SUSPEND test case.

What was once psci_cpu_on_test was renamed and extended to squeeze in a
test case for PSCI SYSTEM_SUSPEND. Nonetheless, the author of those
changes (whoever they may be...) failed to update the file comment to
reflect what had changed.

Reported-by: Reiji Watanabe <[email protected]>
Signed-off-by: Oliver Upton <[email protected]>
---

Forgetting the name of the darned UAPI event. Tsk tsk.

tools/testing/selftests/kvm/aarch64/psci_test.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/kvm/aarch64/psci_test.c b/tools/testing/selftests/kvm/aarch64/psci_test.c
index f7621f6e938e..e0b9e81a3e09 100644
--- a/tools/testing/selftests/kvm/aarch64/psci_test.c
+++ b/tools/testing/selftests/kvm/aarch64/psci_test.c
@@ -1,12 +1,14 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
- * psci_cpu_on_test - Test that the observable state of a vCPU targeted by the
- * CPU_ON PSCI call matches what the caller requested.
+ * psci_test - Tests relating to KVM's PSCI implementation.
*
* Copyright (c) 2021 Google LLC.
*
- * This is a regression test for a race between KVM servicing the PSCI call and
- * userspace reading the vCPUs registers.
+ * This test includes:
+ * - A regression test for a race between KVM servicing the PSCI CPU_ON call
+ * and userspace reading the targeted vCPU's registers.
+ * - A test for KVM's handling of PSCI SYSTEM_SUSPEND and the associated
+ * KVM_SYSTEM_EVENT_SUSPEND UAPI.
*/

#define _GNU_SOURCE

base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
--
2.37.1.595.g718a3a8f04-goog

2022-09-28 16:14:21

by Marc Zyngier

Subject: Re: [RESEND PATCH] KVM: selftests: Update top-of-file comment in psci_test

On Fri, 19 Aug 2022 16:21:00 +0000, Oliver Upton wrote:
> Fix the comment to accurately describe the test and recently added
> SYSTEM_SUSPEND test case.
>
> What was once psci_cpu_on_test was renamed and extended to squeeze in a
> test case for PSCI SYSTEM_SUSPEND. Nonetheless, the author of those
> changes (whoever they may be...) failed to update the file comment to
> reflect what had changed.

Applied to next, thanks!

[1/1] KVM: selftests: Update top-of-file comment in psci_test
commit: 448e711693e48d03f7933ab3673334701b0c3f41

Cheers,

M.
--
Without deviation from the norm, progress is not possible.