2022-09-22 14:49:36

by James Clark

Subject: [PATCH v2 0/1] arm64: defconfig: Add Coresight as module

I'm still leaving out CONFIG_CORESIGHT_SOURCE_ETM4X because it depends
on the outcome of the investigation into CONFIG_PID_IN_CONTEXTIDR, but
I think we should enable these ones for now and start getting some of
the benefits sooner.

Changes since v1:

* Remove CONFIG_CORESIGHT_CTI_INTEGRATION_REGS=y which shouldn't be
enabled by default

-----

As suggested by Catalin here's the change to add Coresight to defconfig.

Unfortunately I don't think we should add CONFIG_CORESIGHT_SOURCE_ETM4X
which builds a few files until [1] is merged because of the overhead
of CONFIG_PID_IN_CONTEXTIDR.

[1]: https://lore.kernel.org/lkml/[email protected]/T/

applies to arm64/for-next/core (e99db032d186)

James Clark (1):
arm64: defconfig: Add Coresight as module

arch/arm64/configs/defconfig | 8 ++++++++
1 file changed, 8 insertions(+)

--
2.28.0

2022-09-22 15:33:41

by James Clark

Subject: [PATCH v2 1/1] arm64: defconfig: Add Coresight as module

Add Coresight to defconfig so that build errors are caught.
CONFIG_CORESIGHT_SOURCE_ETM4X is excluded because it depends on
CONFIG_PID_IN_CONTEXTIDR which has a performance cost.

Signed-off-by: James Clark <[email protected]>
---
arch/arm64/configs/defconfig | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index ef3467092ded..d699933cab45 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1340,4 +1340,12 @@ CONFIG_DEBUG_FS=y
# CONFIG_SCHED_DEBUG is not set
# CONFIG_DEBUG_PREEMPT is not set
# CONFIG_FTRACE is not set
+CONFIG_CORESIGHT=m
+CONFIG_CORESIGHT_LINK_AND_SINK_TMC=m
+CONFIG_CORESIGHT_CATU=m
+CONFIG_CORESIGHT_SINK_TPIU=m
+CONFIG_CORESIGHT_SINK_ETBV10=m
+CONFIG_CORESIGHT_STM=m
+CONFIG_CORESIGHT_CPU_DEBUG=m
+CONFIG_CORESIGHT_CTI=m
CONFIG_MEMTEST=y
--
2.28.0

2022-09-29 18:08:33

by Catalin Marinas

Subject: Re: [PATCH v2 0/1] arm64: defconfig: Add Coresight as module

On Thu, 22 Sep 2022 15:23:59 +0100, James Clark wrote:
> I'm still leaving out CONFIG_CORESIGHT_SOURCE_ETM4X because it depends
> on the outcome of the investigation into CONFIG_PID_IN_CONTEXTIDR, but
> I think we should enable these ones for now and start getting some of
> the benefits sooner.
>
> Changes since v1:
>
> [...]

Applied to arm64 (for-next/defconfig), thanks!

[1/1] arm64: defconfig: Add Coresight as module
https://git.kernel.org/arm64/c/d56f66d2bd4a

--
Catalin