2022-08-18 12:48:09

by Johnson Wang

[permalink] [raw]
Subject: [PATCH RESEND] dt-bindings: timer: Add compatible for MediaTek MT8188

Add dt-binding documentation of timer for MediaTek MT8188 SoC
platform.

Signed-off-by: Johnson Wang <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
index f1c848af91d3..8bbb6e94508b 100644
--- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
+++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
@@ -25,6 +25,7 @@ Required properties:
For those SoCs that use SYST
* "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
* "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
+ * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)
* "mediatek,mt8192-timer" for MT8192 compatible timers (SYST)
* "mediatek,mt8195-timer" for MT8195 compatible timers (SYST)
* "mediatek,mt7629-timer" for MT7629 compatible timers (SYST)
--
2.18.0


2022-08-18 13:02:55

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH RESEND] dt-bindings: timer: Add compatible for MediaTek MT8188

On 18/08/2022 15:46, Johnson Wang wrote:
> Add dt-binding documentation of timer for MediaTek MT8188 SoC
> platform.
>
> Signed-off-by: Johnson Wang <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> index f1c848af91d3..8bbb6e94508b 100644
> --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> @@ -25,6 +25,7 @@ Required properties:
> For those SoCs that use SYST
> * "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
> * "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
> + * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)

Where is the driver change implementing this?

Best regards,
Krzysztof

2022-08-18 14:04:55

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH RESEND] dt-bindings: timer: Add compatible for MediaTek MT8188

On 18/08/2022 15:51, Krzysztof Kozlowski wrote:
> On 18/08/2022 15:46, Johnson Wang wrote:
>> Add dt-binding documentation of timer for MediaTek MT8188 SoC
>> platform.
>>
>> Signed-off-by: Johnson Wang <[email protected]>
>> Acked-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
>> index f1c848af91d3..8bbb6e94508b 100644
>> --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
>> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
>> @@ -25,6 +25,7 @@ Required properties:
>> For those SoCs that use SYST
>> * "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
>> * "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
>> + * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)
>
> Where is the driver change implementing this?

Or is there a generic fallback and you just added a specific one (not
visible on the diff)?

Best regards,
Krzysztof

2022-08-19 02:09:25

by Johnson Wang

[permalink] [raw]
Subject: Re: [PATCH RESEND] dt-bindings: timer: Add compatible for MediaTek MT8188

On Thu, 2022-08-18 at 16:40 +0300, Krzysztof Kozlowski wrote:
> On 18/08/2022 15:51, Krzysztof Kozlowski wrote:
> > On 18/08/2022 15:46, Johnson Wang wrote:
> > > Add dt-binding documentation of timer for MediaTek MT8188 SoC
> > > platform.
> > >
> > > Signed-off-by: Johnson Wang <[email protected]>
> > > Acked-by: Krzysztof Kozlowski <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt |
> > > 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> > > b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> > > index f1c848af91d3..8bbb6e94508b 100644
> > > --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-
> > > timer.txt
> > > +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-
> > > timer.txt
> > > @@ -25,6 +25,7 @@ Required properties:
> > > For those SoCs that use SYST
> > > * "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
> > > * "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
> > > + * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)
> >
> > Where is the driver change implementing this?
>
> Or is there a generic fallback and you just added a specific one (not
> visible on the diff)?
>
> Best regards,
> Krzysztof

Hi Krzysztof,

Yes, MT8188 uses "mediatek,mt6765-timer" as fallback compatible.

BRs,
Johnson Wang

2022-09-20 06:22:11

by Johnson Wang

[permalink] [raw]
Subject: Re: [PATCH RESEND] dt-bindings: timer: Add compatible for MediaTek MT8188

On Thu, 2022-08-18 at 20:46 +0800, Johnson Wang wrote:
> Add dt-binding documentation of timer for MediaTek MT8188 SoC
> platform.
>
> Signed-off-by: Johnson Wang <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-
> timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-
> timer.txt
> index f1c848af91d3..8bbb6e94508b 100644
> --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> @@ -25,6 +25,7 @@ Required properties:
> For those SoCs that use SYST
> * "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
> * "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
> + * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)
> * "mediatek,mt8192-timer" for MT8192 compatible timers (SYST)
> * "mediatek,mt8195-timer" for MT8195 compatible timers (SYST)
> * "mediatek,mt7629-timer" for MT7629 compatible timers (SYST)

Hi Daniel,

Just a gentle ping on this.
Could you please review this patch and give us some suggestion?

Thanks.


BRs,
Johnson Wang

2022-09-20 09:28:41

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH RESEND] dt-bindings: timer: Add compatible for MediaTek MT8188

On 20/09/2022 07:20, Johnson Wang wrote:
> On Thu, 2022-08-18 at 20:46 +0800, Johnson Wang wrote:
>> Add dt-binding documentation of timer for MediaTek MT8188 SoC
>> platform.
>>
>> Signed-off-by: Johnson Wang <[email protected]>
>> Acked-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-
>> timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-
>> timer.txt
>> index f1c848af91d3..8bbb6e94508b 100644
>> --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
>> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
>> @@ -25,6 +25,7 @@ Required properties:
>> For those SoCs that use SYST
>> * "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
>> * "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
>> + * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)
>> * "mediatek,mt8192-timer" for MT8192 compatible timers (SYST)
>> * "mediatek,mt8195-timer" for MT8195 compatible timers (SYST)
>> * "mediatek,mt7629-timer" for MT7629 compatible timers (SYST)
>
> Hi Daniel,
>
> Just a gentle ping on this.
> Could you please review this patch and give us some suggestion?


I've applied the patch

Thanks

-- D.


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2022-10-04 09:48:10

by tip-bot2 for Haifeng Xu

[permalink] [raw]
Subject: [tip: timers/core] dt-bindings: timer: Add compatible for MediaTek MT8188

The following commit has been merged into the timers/core branch of tip:

Commit-ID: b830774c7e4168997ba42deb186f72e6a845742b
Gitweb: https://git.kernel.org/tip/b830774c7e4168997ba42deb186f72e6a845742b
Author: Johnson Wang <[email protected]>
AuthorDate: Thu, 18 Aug 2022 20:46:02 +08:00
Committer: Daniel Lezcano <[email protected]>
CommitterDate: Fri, 19 Aug 2022 11:06:54 +02:00

dt-bindings: timer: Add compatible for MediaTek MT8188

Add dt-binding documentation of timer for MediaTek MT8188 SoC
platform.

Signed-off-by: Johnson Wang <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Daniel Lezcano <[email protected]>
---
Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
index f1c848a..8bbb6e9 100644
--- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
+++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
@@ -25,6 +25,7 @@ Required properties:
For those SoCs that use SYST
* "mediatek,mt8183-timer" for MT8183 compatible timers (SYST)
* "mediatek,mt8186-timer" for MT8186 compatible timers (SYST)
+ * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST)
* "mediatek,mt8192-timer" for MT8192 compatible timers (SYST)
* "mediatek,mt8195-timer" for MT8195 compatible timers (SYST)
* "mediatek,mt7629-timer" for MT7629 compatible timers (SYST)