From: Justin Chen <[email protected]>
A few suspend/resume bug fixes with clocks and wake counter. Also improve
port mode selection.
Al Cooper (1):
phy: usb: s2 WoL wakeup_count not incremented for USB->Eth devices
Justin Chen (5):
phy: usb: Improve port mode selection
phy: usb: Migrate to BIT and BITMASK macros
phy: usb: Disable phy auto-suspend
phy: usb: Use slow clock for wake enabled suspend
phy: usb: Fix clock imbalance for suspend/resume
drivers/phy/broadcom/phy-brcm-usb-init-synopsys.c | 95 ++++++++++++-----------
drivers/phy/broadcom/phy-brcm-usb-init.c | 90 ++++++++++-----------
drivers/phy/broadcom/phy-brcm-usb-init.h | 11 ++-
drivers/phy/broadcom/phy-brcm-usb.c | 28 ++++---
4 files changed, 116 insertions(+), 108 deletions(-)
--
2.7.4
From: Justin Chen <[email protected]>
The logic was incorrect when switching to slow clock. We want the slow
clock if wake_enabled is set.
Fixes: ae532b2b7aa5 ("usb: Add "wake on" functionality for newer Synopsis XHCI controllers")
Signed-off-by: Justin Chen <[email protected]>
---
drivers/phy/broadcom/phy-brcm-usb-init-synopsys.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/broadcom/phy-brcm-usb-init-synopsys.c b/drivers/phy/broadcom/phy-brcm-usb-init-synopsys.c
index 6a4d478..f78cff2 100644
--- a/drivers/phy/broadcom/phy-brcm-usb-init-synopsys.c
+++ b/drivers/phy/broadcom/phy-brcm-usb-init-synopsys.c
@@ -337,13 +337,12 @@ static void usb_uninit_common_7216(struct brcm_usb_init_params *params)
pr_debug("%s\n", __func__);
- if (!params->wake_enabled) {
- USB_CTRL_SET(ctrl, USB_PM, USB_PWRDN);
-
+ if (params->wake_enabled) {
/* Switch to using slower clock during suspend to save power */
USB_CTRL_SET(ctrl, USB_PM, XHC_S2_CLK_SWITCH_EN);
- } else {
usb_wake_enable_7216(params, true);
+ } else {
+ USB_CTRL_SET(ctrl, USB_PM, USB_PWRDN);
}
}
--
2.7.4
On 10/5/2022 2:30 PM, [email protected] wrote:
> From: Justin Chen <[email protected]>
>
> The logic was incorrect when switching to slow clock. We want the slow
> clock if wake_enabled is set.
>
> Fixes: ae532b2b7aa5 ("usb: Add "wake on" functionality for newer Synopsis XHCI controllers")
> Signed-off-by: Justin Chen <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
--
Florian
On Wed, Oct 5, 2022 at 2:30 PM <[email protected]> wrote:
>
> From: Justin Chen <[email protected]>
>
> A few suspend/resume bug fixes with clocks and wake counter. Also improve
> port mode selection.
>
> Al Cooper (1):
> phy: usb: s2 WoL wakeup_count not incremented for USB->Eth devices
>
> Justin Chen (5):
> phy: usb: Improve port mode selection
> phy: usb: Migrate to BIT and BITMASK macros
> phy: usb: Disable phy auto-suspend
> phy: usb: Use slow clock for wake enabled suspend
> phy: usb: Fix clock imbalance for suspend/resume
>
> drivers/phy/broadcom/phy-brcm-usb-init-synopsys.c | 95 ++++++++++++-----------
> drivers/phy/broadcom/phy-brcm-usb-init.c | 90 ++++++++++-----------
> drivers/phy/broadcom/phy-brcm-usb-init.h | 11 ++-
> drivers/phy/broadcom/phy-brcm-usb.c | 28 ++++---
> 4 files changed, 116 insertions(+), 108 deletions(-)
>
> --
> 2.7.4
>
Friendly ping. Any updates on this patch set?
Thanks,
Justin
On 05-10-22, 14:30, [email protected] wrote:
> From: Justin Chen <[email protected]>
>
> A few suspend/resume bug fixes with clocks and wake counter. Also improve
> port mode selection.
Pls order fixes first, that way they can go into -rc.
I have applied these, thanks
--
~Vinod