2022-09-28 09:16:22

by Jensen Huang

[permalink] [raw]
Subject: [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on nanopi4

Internal pull-down for strobe line (GRF_EMMCPHY_CON2[9]) was disabled
by commit 8b5c2b45b8f0, which causes I/O error in HS400 mode.

Tested on NanoPC-T4.

Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in dts")
Signed-off-by: Jensen Huang <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
index 278123b4f911..b6e082f1f6d9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
@@ -167,6 +167,7 @@ &cpu_l3 {
};

&emmc_phy {
+ rockchip,enable-strobe-pulldown;
status = "okay";
};

--
2.37.0


2022-10-17 12:41:39

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on nanopi4

On Wed, 28 Sep 2022 17:11:29 +0800, Jensen Huang wrote:
> Internal pull-down for strobe line (GRF_EMMCPHY_CON2[9]) was disabled
> by commit 8b5c2b45b8f0, which causes I/O error in HS400 mode.
>
> Tested on NanoPC-T4.
>
>

Applied, thanks!

[1/1] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on nanopi4
commit: 463be3cb357dab7d7e4d8dcc7c15c642e10c5bef

Best regards,
--
Heiko Stuebner <[email protected]>