2022-10-15 01:27:43

by Stephen Boyd

[permalink] [raw]
Subject: [PATCH RESEND 1/2] soc: qcom: cmd-db: Mark device as having no PM support

This driver purely exposes information from memory to the kernel. Let's
mark it as not having any device PM functionality, so that during
suspend we skip even trying to call a suspend function on this device.
This clears up suspend logs more than anything else, but it also shaves
a few cycles off suspend.

Cc: Konrad Dybcio <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---

Resend to fix Bjorn's email.

drivers/soc/qcom/cmd-db.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
index 629a7188b576..33856abd560c 100644
--- a/drivers/soc/qcom/cmd-db.c
+++ b/drivers/soc/qcom/cmd-db.c
@@ -338,6 +338,8 @@ static int cmd_db_dev_probe(struct platform_device *pdev)

debugfs_create_file("cmd-db", 0400, NULL, NULL, &cmd_db_debugfs_ops);

+ device_set_pm_not_required(&pdev->dev);
+
return 0;
}


base-commit: 4fe89d07dcc2804c8b562f6c7896a45643d34b2f
--
https://chromeos.dev


2022-10-15 01:27:43

by Stephen Boyd

[permalink] [raw]
Subject: [PATCH RESEND 2/2] soc: qcom: stats: Mark device as having no PM support

This driver purely exposes information from memory to the kernel. Let's
mark it as not having any device PM functionality, so that during
suspend we skip even trying to call a suspend function on this device.
This clears up suspend logs more than anything else, but it also shaves
a few cycles off suspend.

Cc: Konrad Dybcio <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/soc/qcom/qcom_stats.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
index d6bfd1bbdc2a..d89453a77408 100644
--- a/drivers/soc/qcom/qcom_stats.c
+++ b/drivers/soc/qcom/qcom_stats.c
@@ -217,6 +217,8 @@ static int qcom_stats_probe(struct platform_device *pdev)

platform_set_drvdata(pdev, root);

+ device_set_pm_not_required(&pdev->dev);
+
return 0;
}

--
https://chromeos.dev

2022-10-18 03:44:07

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH RESEND 1/2] soc: qcom: cmd-db: Mark device as having no PM support

On Fri, 14 Oct 2022 17:49:33 -0700, Stephen Boyd wrote:
> This driver purely exposes information from memory to the kernel. Let's
> mark it as not having any device PM functionality, so that during
> suspend we skip even trying to call a suspend function on this device.
> This clears up suspend logs more than anything else, but it also shaves
> a few cycles off suspend.
>
>
> [...]

Applied, thanks!

[1/2] soc: qcom: cmd-db: Mark device as having no PM support
commit: 5f7e2cb56af6800a4158514cc27921141e67ae19
[2/2] soc: qcom: stats: Mark device as having no PM support
commit: 367b9c70e9b25fe9ad5346b0f3544682d8b112b9

Best regards,
--
Bjorn Andersson <[email protected]>