2022-10-09 06:15:13

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] scsi: qedf: Remove set but unused variable 'page'

The variable page is not effectively used in the function, so delete
it.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2348
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/scsi/qedf/qedf_main.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index e045c6e25090..35e16600fc63 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -2951,7 +2951,6 @@ static int qedf_alloc_bdq(struct qedf_ctx *qedf)
int i;
struct scsi_bd *pbl;
u64 *list;
- dma_addr_t page;

/* Alloc dma memory for BDQ buffers */
for (i = 0; i < QEDF_BDQ_SIZE; i++) {
@@ -3012,11 +3011,9 @@ static int qedf_alloc_bdq(struct qedf_ctx *qedf)
qedf->bdq_pbl_list_num_entries = qedf->bdq_pbl_mem_size /
QEDF_PAGE_SIZE;
list = (u64 *)qedf->bdq_pbl_list;
- page = qedf->bdq_pbl_list_dma;
for (i = 0; i < qedf->bdq_pbl_list_num_entries; i++) {
*list = qedf->bdq_pbl_dma;
list++;
- page += QEDF_PAGE_SIZE;
}

return 0;
--
2.20.1.7.g153144c


2022-10-27 03:36:52

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: qedf: Remove set but unused variable 'page'

On Sun, 9 Oct 2022 14:02:49 +0800, Jiapeng Chong wrote:

> The variable page is not effectively used in the function, so delete
> it.
>
>

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: qedf: Remove set but unused variable 'page'
https://git.kernel.org/mkp/scsi/c/e6f8a22ff4a1

--
Martin K. Petersen Oracle Linux Engineering