2022-10-27 09:31:15

by Mukesh Ojha

Subject: [PATCH 2/2] f2fs: fix the msg data type

Data type of msg in f2fs_write_checkpoint trace should
be const char * instead of char *.

Signed-off-by: Mukesh Ojha <[email protected]>
---
include/trace/events/f2fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
index ff57e7f..7fbfce4 100644
--- a/include/trace/events/f2fs.h
+++ b/include/trace/events/f2fs.h
@@ -1404,7 +1404,7 @@ TRACE_EVENT(f2fs_readpages,

TRACE_EVENT(f2fs_write_checkpoint,

- TP_PROTO(struct super_block *sb, int reason, char *msg),
+ TP_PROTO(struct super_block *sb, int reason, const char *msg),

TP_ARGS(sb, reason, msg),

--
2.7.4

2022-10-27 10:44:11

by Pavan Kondeti

Subject: Re: [PATCH 2/2] f2fs: fix the msg data type

On Thu, Oct 27, 2022 at 03:47:02PM +0530, Pavan Kondeti wrote:
> On Thu, Oct 27, 2022 at 02:42:41PM +0530, Mukesh Ojha wrote:
> > Data type of msg in f2fs_write_checkpoint trace should
> > be const char * instead of char *.
> >
> > Signed-off-by: Mukesh Ojha <[email protected]>
> > ---
> > include/trace/events/f2fs.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
> > index ff57e7f..7fbfce4 100644
> > --- a/include/trace/events/f2fs.h
> > +++ b/include/trace/events/f2fs.h
> > @@ -1404,7 +1404,7 @@ TRACE_EVENT(f2fs_readpages,
> >
> > TRACE_EVENT(f2fs_write_checkpoint,
> >
> > - TP_PROTO(struct super_block *sb, int reason, char *msg),
> > + TP_PROTO(struct super_block *sb, int reason, const char *msg),
> >
> > TP_ARGS(sb, reason, msg),
> >
> LGTM. one minor comment.
>
> Declare it const char pointer in the trace point structure also.
>
> diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
> index 11f6b71..22960e6 100644
> --- a/include/trace/events/f2fs.h
> +++ b/include/trace/events/f2fs.h
> @@ -1429,7 +1429,7 @@ TRACE_EVENT(f2fs_write_checkpoint,
> TP_STRUCT__entry(
> __field(dev_t, dev)
> __field(int, reason)
> - __field(char *, msg)
> + __field(const char *, msg)
> ),
>
> TP_fast_assign(
>
Never mind, I saw your other patch which makes it a string. Actually, we don't
need a string here as all the invocations (currently) are from ro strings like
below

trace_f2fs_write_checkpoint(sbi->sb, cpc->reason, "start block_ops");
trace_f2fs_write_checkpoint(sbi->sb, cpc->reason, "finish block_ops");
trace_f2fs_write_checkpoint(sbi->sb, cpc->reason, "finish checkpoint");

Thanks,
Pavan

2022-10-27 10:53:10

by Pavan Kondeti

Subject: Re: [PATCH 2/2] f2fs: fix the msg data type

On Thu, Oct 27, 2022 at 02:42:41PM +0530, Mukesh Ojha wrote:
> Data type of msg in f2fs_write_checkpoint trace should
> be const char * instead of char *.
>
> Signed-off-by: Mukesh Ojha <[email protected]>
> ---
> include/trace/events/f2fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
> index ff57e7f..7fbfce4 100644
> --- a/include/trace/events/f2fs.h
> +++ b/include/trace/events/f2fs.h
> @@ -1404,7 +1404,7 @@ TRACE_EVENT(f2fs_readpages,
>
> TRACE_EVENT(f2fs_write_checkpoint,
>
> - TP_PROTO(struct super_block *sb, int reason, char *msg),
> + TP_PROTO(struct super_block *sb, int reason, const char *msg),
>
> TP_ARGS(sb, reason, msg),
>
LGTM. one minor comment.

Declare it const char pointer in the trace point structure also.

diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
index 11f6b71..22960e6 100644
--- a/include/trace/events/f2fs.h
+++ b/include/trace/events/f2fs.h
@@ -1429,7 +1429,7 @@ TRACE_EVENT(f2fs_write_checkpoint,
TP_STRUCT__entry(
__field(dev_t, dev)
__field(int, reason)
- __field(char *, msg)
+ __field(const char *, msg)
),

TP_fast_assign(

Thanks,
Pavan

2022-10-29 03:33:05

by Chao Yu

Subject: Re: [PATCH 2/2] f2fs: fix the msg data type

On 2022/10/27 17:12, Mukesh Ojha wrote:
> Data type of msg in f2fs_write_checkpoint trace should
> be const char * instead of char *.
>
> Signed-off-by: Mukesh Ojha <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,