2022-10-28 14:23:42

by Cristian Marussi

Subject: [PATCH 8/8] arm64: dts: juno: Add Thermal critical trip points

When thernal zones are defined, trip points definitions are mandatory.
Define a couple of critical trip points for monitoring of existing
PMIC and SOC thermale zones.

Cc: Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: [email protected]
Signed-off-by: Cristian Marussi <[email protected]>
----
Not sure if we want to add a:

Fixes: f7b636a8d83c ("arm64: dts: juno: add thermal zones for scpi sensors")
---
arch/arm64/boot/dts/arm/juno-base.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index 2f27619d8abd..8b4d280b1e7e 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -751,12 +751,26 @@ pmic {
polling-delay = <1000>;
polling-delay-passive = <100>;
thermal-sensors = <&scpi_sensors0 0>;
+ trips {
+ pmic_crit0: trip0 {
+ temperature = <90000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
};

soc {
polling-delay = <1000>;
polling-delay-passive = <100>;
thermal-sensors = <&scpi_sensors0 3>;
+ trips {
+ soc_crit0: trip0 {
+ temperature = <80000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
};

big_cluster_thermal_zone: big-cluster {
--
2.34.1

2022-11-03 07:51:25

by Sudeep Holla

Subject: Re: [PATCH 8/8] arm64: dts: juno: Add Thermal critical trip points

On Fri, 28 Oct 2022 15:08:26 +0100, Cristian Marussi wrote:
> When thermnal zones are defined, trip points definitions are mandatory.
> Define a couple of critical trip points for monitoring of existing
> PMIC and SOC thermal zones.

> This was lost between txt to yaml conversion and was re-enforced recently
> via the commit 8c596324232d ("dt-bindings: thermal: Fix missing required property")
>
> [...]

Applied to sudeep.holla/linux (for-next/juno), thanks!

[8/8] arm64: dts: juno: Add Thermal critical trip points
https://git.kernel.org/sudeep.holla/c/c4a7b9b587ca

--
Regards,
Sudeep