Hi,
Changes since v3
================
1. Drop bindings patch: applied.
2. Rebase.
3. Add tags.
Changes since v2
================
1. New patch: revert of glitch SPI CS workaround
2. dt-bindings: Drop entire drive-strength (not needed, brought by common TLMM
schema).
3. Add tags.
v2: https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof
Krzysztof Kozlowski (3):
arm64: dts: qcom: sc7180-trogdor-homestar: fully configure secondary
I2S pins
arm64: dts: qcom: sc7180: revert "arm64: dts: qcom: sc7180: Avoid
glitching SPI CS at bootup on trogdor"
arm64: dts: qcom: sc7180: align TLMM pin configuration with DT schema
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 236 +++----
.../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 36 +-
.../dts/qcom/sc7180-trogdor-homestar.dtsi | 41 +-
.../dts/qcom/sc7180-trogdor-kingoftown-r0.dts | 16 +-
.../dts/qcom/sc7180-trogdor-kingoftown.dtsi | 8 +-
.../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 16 +-
.../dts/qcom/sc7180-trogdor-mrbland-rev0.dtsi | 25 +-
.../boot/dts/qcom/sc7180-trogdor-mrbland.dtsi | 72 +-
.../qcom/sc7180-trogdor-parade-ps8640.dtsi | 32 +-
.../boot/dts/qcom/sc7180-trogdor-pazquel.dtsi | 8 +-
.../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 14 +-
.../qcom/sc7180-trogdor-quackingstick.dtsi | 56 +-
.../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 8 +-
.../dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi | 16 +-
.../qcom/sc7180-trogdor-wormdingler-rev0.dtsi | 25 +-
.../dts/qcom/sc7180-trogdor-wormdingler.dtsi | 72 +-
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 650 +++++++-----------
arch/arm64/boot/dts/qcom/sc7180.dtsi | 597 ++++++++--------
18 files changed, 776 insertions(+), 1152 deletions(-)
--
2.34.1
The Trogdor Homestar DTSI adds additional GPIO52 pin to secondary I2S pins
("sec_mi2s_active") and configures it to "mi2s_1" function.
The Trogdor DTSI (which is included by Homestar) configures drive
strength and bias for all "sec_mi2s_active" pins, thus the intention was
to apply this configuration also to GPIO52 on Homestar.
Reported-by: Doug Anderson <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Fixes: be0416a3f917 ("arm64: dts: qcom: Add sc7180-trogdor-homestar")
Reviewed-by: Douglas Anderson <[email protected]>
---
Changes since v3:
1. None
Changes since v2:
1. Add tags.
Changes since v1:
1. New patch
Not tested on hardware.
Cc: Doug Anderson <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi
index 7fcff4eddd3a..8264b8d5e778 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi
@@ -194,6 +194,12 @@ pinmux {
pins = "gpio49", "gpio50", "gpio51", "gpio52";
function = "mi2s_1";
};
+
+ pinconf {
+ pins = "gpio49", "gpio50", "gpio51", "gpio52";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
};
&ts_reset_l {
--
2.34.1
Bjorn,
On Thu, Oct 20, 2022 at 3:51 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> Hi,
>
> Changes since v3
> ================
> 1. Drop bindings patch: applied.
> 2. Rebase.
> 3. Add tags.
>
> Changes since v2
> ================
> 1. New patch: revert of glitch SPI CS workaround
> 2. dt-bindings: Drop entire drive-strength (not needed, brought by common TLMM
> schema).
> 3. Add tags.
> v2: https://lore.kernel.org/all/[email protected]/
>
> Best regards,
> Krzysztof
>
> Krzysztof Kozlowski (3):
> arm64: dts: qcom: sc7180-trogdor-homestar: fully configure secondary
> I2S pins
> arm64: dts: qcom: sc7180: revert "arm64: dts: qcom: sc7180: Avoid
> glitching SPI CS at bootup on trogdor"
> arm64: dts: qcom: sc7180: align TLMM pin configuration with DT schema
>
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 236 +++----
> .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 36 +-
> .../dts/qcom/sc7180-trogdor-homestar.dtsi | 41 +-
> .../dts/qcom/sc7180-trogdor-kingoftown-r0.dts | 16 +-
> .../dts/qcom/sc7180-trogdor-kingoftown.dtsi | 8 +-
> .../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 16 +-
> .../dts/qcom/sc7180-trogdor-mrbland-rev0.dtsi | 25 +-
> .../boot/dts/qcom/sc7180-trogdor-mrbland.dtsi | 72 +-
> .../qcom/sc7180-trogdor-parade-ps8640.dtsi | 32 +-
> .../boot/dts/qcom/sc7180-trogdor-pazquel.dtsi | 8 +-
> .../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 14 +-
> .../qcom/sc7180-trogdor-quackingstick.dtsi | 56 +-
> .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 8 +-
> .../dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi | 16 +-
> .../qcom/sc7180-trogdor-wormdingler-rev0.dtsi | 25 +-
> .../dts/qcom/sc7180-trogdor-wormdingler.dtsi | 72 +-
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 650 +++++++-----------
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 597 ++++++++--------
> 18 files changed, 776 insertions(+), 1152 deletions(-)
I'd love to see this series land sooner rather than later. It'll cause
conflicts with pretty much any other patch to a sc7180 device tree
file, so it'd be nice to get it in the tree. ;-)
-Doug
On 26/10/2022 11:33, Doug Anderson wrote:
> Bjorn,
>
> On Thu, Oct 20, 2022 at 3:51 PM Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> Hi,
>>
>> Changes since v3
>> ================
>> 1. Drop bindings patch: applied.
>> 2. Rebase.
>> 3. Add tags.
>>
>> Changes since v2
>> ================
>> 1. New patch: revert of glitch SPI CS workaround
>> 2. dt-bindings: Drop entire drive-strength (not needed, brought by common TLMM
>> schema).
>> 3. Add tags.
>> v2: https://lore.kernel.org/all/[email protected]/
>>
>> Best regards,
>> Krzysztof
>>
>> Krzysztof Kozlowski (3):
>> arm64: dts: qcom: sc7180-trogdor-homestar: fully configure secondary
>> I2S pins
>> arm64: dts: qcom: sc7180: revert "arm64: dts: qcom: sc7180: Avoid
>> glitching SPI CS at bootup on trogdor"
>> arm64: dts: qcom: sc7180: align TLMM pin configuration with DT schema
>>
>> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 236 +++----
>> .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 36 +-
>> .../dts/qcom/sc7180-trogdor-homestar.dtsi | 41 +-
>> .../dts/qcom/sc7180-trogdor-kingoftown-r0.dts | 16 +-
>> .../dts/qcom/sc7180-trogdor-kingoftown.dtsi | 8 +-
>> .../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 16 +-
>> .../dts/qcom/sc7180-trogdor-mrbland-rev0.dtsi | 25 +-
>> .../boot/dts/qcom/sc7180-trogdor-mrbland.dtsi | 72 +-
>> .../qcom/sc7180-trogdor-parade-ps8640.dtsi | 32 +-
>> .../boot/dts/qcom/sc7180-trogdor-pazquel.dtsi | 8 +-
>> .../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 14 +-
>> .../qcom/sc7180-trogdor-quackingstick.dtsi | 56 +-
>> .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 8 +-
>> .../dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi | 16 +-
>> .../qcom/sc7180-trogdor-wormdingler-rev0.dtsi | 25 +-
>> .../dts/qcom/sc7180-trogdor-wormdingler.dtsi | 72 +-
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 650 +++++++-----------
>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 597 ++++++++--------
>> 18 files changed, 776 insertions(+), 1152 deletions(-)
>
> I'd love to see this series land sooner rather than later. It'll cause
Yeah, me too...
> conflicts with pretty much any other patch to a sc7180 device tree
> file, so it'd be nice to get it in the tree. ;-)
It's not only about these series but a bunch of others:
ARM: dts: qcom: msm8974: align TLMM pin configuration with DT schema
... although I see now that some were applied and I did not get any
notification from patchwork.
Best regards,
Krzysztof
Quoting Krzysztof Kozlowski (2022-10-20 15:51:33)
> The Trogdor Homestar DTSI adds additional GPIO52 pin to secondary I2S pins
> ("sec_mi2s_active") and configures it to "mi2s_1" function.
>
> The Trogdor DTSI (which is included by Homestar) configures drive
> strength and bias for all "sec_mi2s_active" pins, thus the intention was
> to apply this configuration also to GPIO52 on Homestar.
>
> Reported-by: Doug Anderson <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Fixes: be0416a3f917 ("arm64: dts: qcom: Add sc7180-trogdor-homestar")
> Reviewed-by: Douglas Anderson <[email protected]>
>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
On Thu, 20 Oct 2022 18:51:32 -0400, Krzysztof Kozlowski wrote:
> Changes since v3
> ================
> 1. Drop bindings patch: applied.
> 2. Rebase.
> 3. Add tags.
>
> Changes since v2
> ================
> 1. New patch: revert of glitch SPI CS workaround
> 2. dt-bindings: Drop entire drive-strength (not needed, brought by common TLMM
> schema).
> 3. Add tags.
> v2: https://lore.kernel.org/all/[email protected]/
>
> [...]
Applied, thanks!
[1/3] arm64: dts: qcom: sc7180-trogdor-homestar: fully configure secondary I2S pins
commit: 59e787935cfe6f562fbb9117e2df4076eaf810d8
[2/3] arm64: dts: qcom: sc7180: revert "arm64: dts: qcom: sc7180: Avoid glitching SPI CS at bootup on trogdor"
commit: 8ddfa04de492ceac93e72063e027216bb9b07ca5
[3/3] arm64: dts: qcom: sc7180: align TLMM pin configuration with DT schema
commit: 2f0300a6946702ff48f6584e0146bbe62c32abac
Best regards,
--
Bjorn Andersson <[email protected]>