2022-11-08 20:38:12

by Alex Elder

[permalink] [raw]
Subject: [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice

In "sc7280-idp.dts", the IPA node is modified after being defined.
However that file includes "sc7280-idp.dtsi", which also modifies
the IPA node (in the same way). This only needs to be done in
"sc7280-idp.dtsi".

Signed-off-by: Alex Elder <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-idp.dts | 5 -----
1 file changed, 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index 7559164cdda08..9ddfdfdd354ee 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -61,11 +61,6 @@ &bluetooth {
vddio-supply = <&vreg_l19b_1p8>;
};

-&ipa {
- status = "okay";
- modem-init;
-};
-
&pmk8350_rtc {
status = "okay";
};
--
2.34.1



2022-11-08 21:01:53

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice

On 08/11/2022 21:16, Alex Elder wrote:
> In "sc7280-idp.dts", the IPA node is modified after being defined.
> However that file includes "sc7280-idp.dtsi", which also modifies
> the IPA node (in the same way). This only needs to be done in
> "sc7280-idp.dtsi".
>


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2022-11-08 21:40:02

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice



On 08/11/2022 21:16, Alex Elder wrote:
> In "sc7280-idp.dts", the IPA node is modified after being defined.
> However that file includes "sc7280-idp.dtsi", which also modifies
> the IPA node (in the same way). This only needs to be done in
> "sc7280-idp.dtsi".
>
> Signed-off-by: Alex Elder <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> index 7559164cdda08..9ddfdfdd354ee 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> @@ -61,11 +61,6 @@ &bluetooth {
> vddio-supply = <&vreg_l19b_1p8>;
> };
>
> -&ipa {
> - status = "okay";
> - modem-init;
> -};
> -
> &pmk8350_rtc {
> status = "okay";
> };

2022-11-10 04:12:20

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice

On Tue, 8 Nov 2022 14:16:25 -0600, Alex Elder wrote:
> In "sc7280-idp.dts", the IPA node is modified after being defined.
> However that file includes "sc7280-idp.dtsi", which also modifies
> the IPA node (in the same way). This only needs to be done in
> "sc7280-idp.dtsi".
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice
commit: d4d4a7c4fd5f1b802ccf329edf11a3ade69b55e0

Best regards,
--
Bjorn Andersson <[email protected]>