Hi,
This converts HYM8563 binding to YAML and fixes
the existing DTs.
Changes since PATCHv1:
* https://lore.kernel.org/all/[email protected]/
* Added patches fixing the existing devicetrees (Rob Herring)
* Dual licensed the binding (Krzysztof Kozlowski)
* Added maxItems for clock-output-names (Krzysztof Kozlowski)
-- Sebastian
Sebastian Reichel (6):
arm64: dts: rockchip: fix node name for hym8563 rtc
arm64: dts: rockchip: remove clock-frequency from rtc
arm: dts: rockchip: fix node name for hym8563 rtc
arm: dts: rockchip: remove clock-frequency from rtc
arm64: dts: meson: remove clock-frequency from rtc
dt-bindings: rtc: convert hym8563 bindings to json-schema
.../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ----------
.../bindings/rtc/haoyu,hym8563.yaml | 56 +++++++++++++++++++
arch/arm/boot/dts/rk3036-evb.dts | 3 +-
arch/arm/boot/dts/rk3288-evb-act8846.dts | 2 +-
arch/arm/boot/dts/rk3288-firefly.dtsi | 3 +-
arch/arm/boot/dts/rk3288-miqi.dts | 3 +-
arch/arm/boot/dts/rk3288-rock2-square.dts | 3 +-
arch/arm/boot/dts/rk3288-vmarc-som.dtsi | 1 -
.../amlogic/meson-gxl-s905x-khadas-vim.dts | 1 -
.../dts/amlogic/meson-gxm-khadas-vim2.dts | 1 -
.../dts/amlogic/meson-gxm-minix-neo-u9h.dts | 1 -
.../dts/rockchip/rk3368-orion-r68-meta.dts | 3 +-
arch/arm64/boot/dts/rockchip/rk3368-r88.dts | 3 +-
.../boot/dts/rockchip/rk3399-roc-pc-plus.dts | 3 +-
.../dts/rockchip/rk3399pro-vmarc-som.dtsi | 3 +-
.../boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 1 -
.../boot/dts/rockchip/rk3568-rock-3a.dts | 1 -
17 files changed, 65 insertions(+), 53 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt
create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
--
2.35.1
Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree
Schema format.
Signed-off-by: Sebastian Reichel <[email protected]>
---
.../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ----------
.../bindings/rtc/haoyu,hym8563.yaml | 56 +++++++++++++++++++
2 files changed, 56 insertions(+), 30 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt
create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt
deleted file mode 100644
index a8934fe2ab4c..000000000000
--- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt
+++ /dev/null
@@ -1,30 +0,0 @@
-Haoyu Microelectronics HYM8563 Real Time Clock
-
-The HYM8563 provides basic rtc and alarm functionality
-as well as a clock output of up to 32kHz.
-
-Required properties:
-- compatible: should be: "haoyu,hym8563"
-- reg: i2c address
-- #clock-cells: the value should be 0
-
-Optional properties:
-- clock-output-names: From common clock binding
-- interrupts: rtc alarm/event interrupt
-
-Example:
-
-hym8563: hym8563@51 {
- compatible = "haoyu,hym8563";
- reg = <0x51>;
-
- interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
-
- #clock-cells = <0>;
-};
-
-device {
-...
- clocks = <&hym8563>;
-...
-};
diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
new file mode 100644
index 000000000000..0b9f39ef0edc
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/haoyu,hym8563.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Haoyu Microelectronics HYM8563 RTC
+
+maintainers:
+ - Alexandre Belloni <[email protected]>
+
+properties:
+ compatible:
+ const: haoyu,hym8563
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ "#clock-cells":
+ const: 0
+
+ clock-output-names:
+ description: From common clock binding to override the default output clock name.
+ maxItems: 1
+
+ wakeup-source:
+ description: Enables wake up of host system on alarm.
+
+allOf:
+ - $ref: rtc.yaml
+
+unevaluatedProperties: false
+
+required:
+ - compatible
+ - reg
+ - "#clock-cells"
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ rtc@51 {
+ compatible = "haoyu,hym8563";
+ reg = <0x51>;
+ interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
+ #clock-cells = <0>;
+ };
+ };
--
2.35.1
'clock-frequency' is not part of the DT binding and not supported by the
Linux driver.
Signed-off-by: Sebastian Reichel <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts | 1 -
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 1 -
arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dts | 1 -
3 files changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
index 6ab1cc125b96..202deb4e2d63 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
@@ -140,7 +140,6 @@ rtc: rtc@51 {
compatible = "haoyu,hym8563";
reg = <0x51>;
#clock-cells = <0>;
- clock-frequency = <32768>;
clock-output-names = "xin32k";
};
};
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index f43c45daf7eb..b21172ece1fa 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -270,7 +270,6 @@ rtc: rtc@51 {
compatible = "haoyu,hym8563";
reg = <0x51>;
#clock-cells = <0>;
- clock-frequency = <32768>;
clock-output-names = "xin32k";
};
};
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dts
index b8ef3bd8b840..1703da3235ea 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dts
@@ -89,7 +89,6 @@ rtc: rtc@51 {
compatible = "haoyu,hym8563";
reg = <0x51>;
#clock-cells = <0>;
- clock-frequency = <32768>;
clock-output-names = "xin32k";
wakeup-source;
};
--
2.35.1
'clock-frequency' is not part of the DT binding and not supported by the
Linux driver.
Signed-off-by: Sebastian Reichel <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3368-orion-r68-meta.dts | 1 -
arch/arm64/boot/dts/rockchip/rk3368-r88.dts | 1 -
arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts | 1 -
arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi | 1 -
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 1 -
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 -
6 files changed, 6 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3368-orion-r68-meta.dts b/arch/arm64/boot/dts/rockchip/rk3368-orion-r68-meta.dts
index 0e88e9592c1c..81d1064fdb21 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-orion-r68-meta.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3368-orion-r68-meta.dts
@@ -212,7 +212,6 @@ hym8563: rtc@51 {
compatible = "haoyu,hym8563";
reg = <0x51>;
#clock-cells = <0>;
- clock-frequency = <32768>;
clock-output-names = "xin32k";
/* rtc_int is not connected */
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3368-r88.dts b/arch/arm64/boot/dts/rockchip/rk3368-r88.dts
index e147d6f8b43e..5589f3db6b36 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-r88.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3368-r88.dts
@@ -196,7 +196,6 @@ hym8563: rtc@51 {
compatible = "haoyu,hym8563";
reg = <0x51>;
#clock-cells = <0>;
- clock-frequency = <32768>;
clock-output-names = "xin32k";
/* rtc_int is not connected */
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts
index 18b5050c6cd3..7ba1c28f70a9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts
@@ -104,7 +104,6 @@ hym8563: rtc@51 {
interrupt-parent = <&gpio0>;
interrupts = <RK_PA5 IRQ_TYPE_EDGE_FALLING>;
#clock-cells = <0>;
- clock-frequency = <32768>;
clock-output-names = "xin32k";
pinctrl-names = "default";
pinctrl-0 = <&hym8563_int>;
diff --git a/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi b/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi
index 6c168566321b..bf9eb0405b62 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi
@@ -301,7 +301,6 @@ hym8563: rtc@51 {
compatible = "haoyu,hym8563";
reg = <0x51>;
#clock-cells = <0>;
- clock-frequency = <32768>;
clock-output-names = "hym8563";
pinctrl-names = "default";
pinctrl-0 = <&hym8563_int>;
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index c282f6e79960..26d7fda275ed 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -500,7 +500,6 @@ hym8563: rtc@51 {
interrupt-parent = <&gpio0>;
interrupts = <RK_PD3 IRQ_TYPE_EDGE_FALLING>;
#clock-cells = <0>;
- clock-frequency = <32768>;
clock-output-names = "rtcic_32kout";
pinctrl-names = "default";
pinctrl-0 = <&hym8563_int>;
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
index fb87a168fe96..539ef8cc7792 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
@@ -509,7 +509,6 @@ hym8563: rtc@51 {
interrupt-parent = <&gpio0>;
interrupts = <RK_PD3 IRQ_TYPE_LEVEL_LOW>;
#clock-cells = <0>;
- clock-frequency = <32768>;
clock-output-names = "rtcic_32kout";
pinctrl-names = "default";
pinctrl-0 = <&hym8563_int>;
--
2.35.1
On 24/10/2022 12:55, Sebastian Reichel wrote:
> Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree
> Schema format.
>
> Signed-off-by: Sebastian Reichel <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
Am Montag, 24. Oktober 2022, 18:55:49 CET schrieb Sebastian Reichel:
> Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree
> Schema format.
>
> Signed-off-by: Sebastian Reichel <[email protected]>
Reviewed-by: Heiko Stuebner <[email protected]>
> ---
> .../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ----------
> .../bindings/rtc/haoyu,hym8563.yaml | 56 +++++++++++++++++++
> 2 files changed, 56 insertions(+), 30 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt
> create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt
> deleted file mode 100644
> index a8934fe2ab4c..000000000000
> --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -Haoyu Microelectronics HYM8563 Real Time Clock
> -
> -The HYM8563 provides basic rtc and alarm functionality
> -as well as a clock output of up to 32kHz.
> -
> -Required properties:
> -- compatible: should be: "haoyu,hym8563"
> -- reg: i2c address
> -- #clock-cells: the value should be 0
> -
> -Optional properties:
> -- clock-output-names: From common clock binding
> -- interrupts: rtc alarm/event interrupt
> -
> -Example:
> -
> -hym8563: hym8563@51 {
> - compatible = "haoyu,hym8563";
> - reg = <0x51>;
> -
> - interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> -
> - #clock-cells = <0>;
> -};
> -
> -device {
> -...
> - clocks = <&hym8563>;
> -...
> -};
> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
> new file mode 100644
> index 000000000000..0b9f39ef0edc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/haoyu,hym8563.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Haoyu Microelectronics HYM8563 RTC
> +
> +maintainers:
> + - Alexandre Belloni <[email protected]>
> +
> +properties:
> + compatible:
> + const: haoyu,hym8563
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + "#clock-cells":
> + const: 0
> +
> + clock-output-names:
> + description: From common clock binding to override the default output clock name.
> + maxItems: 1
> +
> + wakeup-source:
> + description: Enables wake up of host system on alarm.
> +
> +allOf:
> + - $ref: rtc.yaml
> +
> +unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - "#clock-cells"
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rtc@51 {
> + compatible = "haoyu,hym8563";
> + reg = <0x51>;
> + interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> + #clock-cells = <0>;
> + };
> + };
>
On Mon, 24 Oct 2022 18:55:43 +0200, Sebastian Reichel wrote:
> This converts HYM8563 binding to YAML and fixes
> the existing DTs.
>
> Changes since PATCHv1:
> * https://lore.kernel.org/all/[email protected]/
> * Added patches fixing the existing devicetrees (Rob Herring)
> * Dual licensed the binding (Krzysztof Kozlowski)
> * Added maxItems for clock-output-names (Krzysztof Kozlowski)
>
> [...]
Applied, thanks!
[1/6] arm64: dts: rockchip: fix node name for hym8563 rtc
commit: 67a9aeef44e42b1ac2becf5e61eae0880f48d9db
[2/6] arm64: dts: rockchip: remove clock-frequency from rtc
commit: 2af5bbe32f50d196dd680478a889d12429b3e8cf
[3/6] arm: dts: rockchip: fix node name for hym8563 rtc
commit: 17b57beafccb4569accbfc8c11390744cf59c021
[4/6] arm: dts: rockchip: remove clock-frequency from rtc
commit: 6122f3be70d90a1b2a1188d8910256fc218376a9
Best regards,
--
Heiko Stuebner <[email protected]>
On 24/10/2022 18:55, Sebastian Reichel wrote:
> 'clock-frequency' is not part of the DT binding and not supported by the
> Linux driver.
>
> Signed-off-by: Sebastian Reichel <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts | 1 -
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 1 -
> arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dts | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
> index 6ab1cc125b96..202deb4e2d63 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
> @@ -140,7 +140,6 @@ rtc: rtc@51 {
> compatible = "haoyu,hym8563";
> reg = <0x51>;
> #clock-cells = <0>;
> - clock-frequency = <32768>;
> clock-output-names = "xin32k";
> };
> };
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> index f43c45daf7eb..b21172ece1fa 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> @@ -270,7 +270,6 @@ rtc: rtc@51 {
> compatible = "haoyu,hym8563";
> reg = <0x51>;
> #clock-cells = <0>;
> - clock-frequency = <32768>;
> clock-output-names = "xin32k";
> };
> };
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dts
> index b8ef3bd8b840..1703da3235ea 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dts
> @@ -89,7 +89,6 @@ rtc: rtc@51 {
> compatible = "haoyu,hym8563";
> reg = <0x51>;
> #clock-cells = <0>;
> - clock-frequency = <32768>;
> clock-output-names = "xin32k";
> wakeup-source;
> };
Reviewed-by: Neil Armstrong <[email protected]>
Hi,
On Mon, 24 Oct 2022 18:55:43 +0200, Sebastian Reichel wrote:
> This converts HYM8563 binding to YAML and fixes
> the existing DTs.
>
> Changes since PATCHv1:
> * https://lore.kernel.org/all/[email protected]/
> * Added patches fixing the existing devicetrees (Rob Herring)
> * Dual licensed the binding (Krzysztof Kozlowski)
> * Added maxItems for clock-output-names (Krzysztof Kozlowski)
>
> [...]
Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.2/arm64-dt)
[5/6] arm64: dts: meson: remove clock-frequency from rtc
https://git.kernel.org/amlogic/c/2c5240a018afd6f46fe648ee2396983f5ce1e087
These changes has been applied on the intermediate git tree [1].
The v6.2/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.
In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].
The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.
If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
--
Neil
On Mon, 24 Oct 2022 18:55:49 +0200, Sebastian Reichel wrote:
> Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree
> Schema format.
>
>
Applied, thanks!
[6/6] dt-bindings: rtc: convert hym8563 bindings to json-schema
commit: e00a89527a497cd49436369b05459be55cb922ba
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com