When reviewing a new devicetree for sa8540p-ride I noticed that the
indentation for the 'regulator-allowed-modes' properties was off and
realised that this had been copied from the recent patches adding the
missing modes properties.
Let's clean up the binding example and current devicetree sources to
avoid this pattern being reproduced further.
Note that the patches adding the missing properties have not yet made it
into 6.1-rc.
Johan
Johan Hovold (2):
regulator: dt-bindings: qcom,rpmh: clean up example indentation
arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation
.../regulator/qcom,rpmh-regulator.yaml | 10 ++++------
arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 20 ++++++++-----------
arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 20 ++++++++-----------
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 10 ++++------
.../qcom/sm6350-sony-xperia-lena-pdx213.dts | 10 ++++------
.../boot/dts/qcom/sm7225-fairphone-fp4.dts | 10 ++++------
.../dts/qcom/sm8150-sony-xperia-kumano.dtsi | 10 ++++------
.../boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 10 ++++------
arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 20 ++++++++-----------
9 files changed, 48 insertions(+), 72 deletions(-)
--
2.37.4
Remove a line break and increase indentation of the continuation line
to avoid having the 'regulator-allowed-modes' example be reproduced
verbatim with four-spaces indentation (instead of a tab, which is still
too little) in devicetree sources.
Signed-off-by: Johan Hovold <[email protected]>
---
.../bindings/regulator/qcom,rpmh-regulator.yaml | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
index 90c3bda31c23..7ff51b558702 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
@@ -412,9 +412,8 @@ examples:
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
};
@@ -431,9 +430,8 @@ examples:
bob {
regulator-min-microvolt = <3312000>;
regulator-max-microvolt = <3600000>;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_AUTO
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_AUTO
+ RPMH_REGULATOR_MODE_HPM>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_AUTO>;
};
};
--
2.37.4
On 16/11/2022 11:20, Johan Hovold wrote:
> Remove a line break and increase indentation of the continuation line
> to avoid having the 'regulator-allowed-modes' example be reproduced
> verbatim with four-spaces indentation (instead of a tab, which is still
> too little) in devicetree sources.
>
> Signed-off-by: Johan Hovold <[email protected]>
> ---
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On Wed, 16 Nov 2022 11:20:52 +0100, Johan Hovold wrote:
> When reviewing a new devicetree for sa8540p-ride I noticed that the
> indentation for the 'regulator-allowed-modes' properties was off and
> realised that this had been copied from the recent patches adding the
> missing modes properties.
>
> Let's clean up the binding example and current devicetree sources to
> avoid this pattern being reproduced further.
>
> [...]
Applied to
broonie/regulator.git for-next
Thanks!
[1/2] regulator: dt-bindings: qcom,rpmh: clean up example indentation
commit: b8dfb3bed5524589052dafa0e4d6c4e25ae11544
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
On Wed, 16 Nov 2022 11:20:52 +0100, Johan Hovold wrote:
> When reviewing a new devicetree for sa8540p-ride I noticed that the
> indentation for the 'regulator-allowed-modes' properties was off and
> realised that this had been copied from the recent patches adding the
> missing modes properties.
>
> Let's clean up the binding example and current devicetree sources to
> avoid this pattern being reproduced further.
>
> [...]
Applied, thanks!
[2/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation
commit: 25f08f02f47d0f83f39308359bad06719ad9a55c
Best regards,
--
Bjorn Andersson <[email protected]>