2022-11-19 03:30:19

by Tiezhu Yang

Subject: [PATCH] tools/vm/slabinfo-gnuplot: Use "grep -E" instead of "egrep"

The latest version of grep claims the egrep is now obsolete so the build
now contains warnings that look like:
egrep: warning: egrep is obsolescent; using grep -E
fix this up by moving the related file to use "grep -E" instead.

sed -i "s/egrep/grep -E/g" `grep egrep -rwl tools/vm`

Here are the steps to install the latest grep:

wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
tar xf grep-3.8.tar.gz
cd grep-3.8 && ./configure && make
sudo make install
export PATH=/usr/local/bin:$PATH

Signed-off-by: Tiezhu Yang <[email protected]>
---
tools/vm/slabinfo-gnuplot.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/vm/slabinfo-gnuplot.sh b/tools/vm/slabinfo-gnuplot.sh
index 26e193f..873a892 100644
--- a/tools/vm/slabinfo-gnuplot.sh
+++ b/tools/vm/slabinfo-gnuplot.sh
@@ -150,7 +150,7 @@ do_preprocess()
let lines=3
out=`basename "$in"`"-slabs-by-loss"
`cat "$in" | grep -A "$lines" 'Slabs sorted by loss' |\
- egrep -iv '\-\-|Name|Slabs'\
+ grep -E -iv '\-\-|Name|Slabs'\
| awk '{print $1" "$4+$2*$3" "$4}' > "$out"`
if [ $? -eq 0 ]; then
do_slabs_plotting "$out"
@@ -159,7 +159,7 @@ do_preprocess()
let lines=3
out=`basename "$in"`"-slabs-by-size"
`cat "$in" | grep -A "$lines" 'Slabs sorted by size' |\
- egrep -iv '\-\-|Name|Slabs'\
+ grep -E -iv '\-\-|Name|Slabs'\
| awk '{print $1" "$4" "$4-$2*$3}' > "$out"`
if [ $? -eq 0 ]; then
do_slabs_plotting "$out"
--
2.1.0

2022-11-21 22:16:25

by Andrew Morton

Subject: Re: [PATCH] tools/vm/slabinfo-gnuplot: Use "grep -E" instead of "egrep"

On Sat, 19 Nov 2022 10:36:59 +0800 Tiezhu Yang <[email protected]> wrote:

> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the related file to use "grep -E" instead.
>
> sed -i "s/egrep/grep -E/g" `grep egrep -rwl tools/vm`
>
> Here are the steps to install the latest grep:
>
> wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
> tar xf grep-3.8.tar.gz
> cd grep-3.8 && ./configure && make
> sudo make install
> export PATH=/usr/local/bin:$PATH
>
> ...
>
> --- a/tools/vm/slabinfo-gnuplot.sh
> +++ b/tools/vm/slabinfo-gnuplot.sh
> @@ -150,7 +150,7 @@ do_preprocess()
> let lines=3
> out=`basename "$in"`"-slabs-by-loss"
> `cat "$in" | grep -A "$lines" 'Slabs sorted by loss' |\
> - egrep -iv '\-\-|Name|Slabs'\
> + grep -E -iv '\-\-|Name|Slabs'\
> | awk '{print $1" "$4+$2*$3" "$4}' > "$out"`
> if [ $? -eq 0 ]; then
> do_slabs_plotting "$out"
> @@ -159,7 +159,7 @@ do_preprocess()
> let lines=3
> out=`basename "$in"`"-slabs-by-size"
> `cat "$in" | grep -A "$lines" 'Slabs sorted by size' |\
> - egrep -iv '\-\-|Name|Slabs'\
> + grep -E -iv '\-\-|Name|Slabs'\
> | awk '{print $1" "$4" "$4-$2*$3}' > "$out"`
> if [ $? -eq 0 ]; then
> do_slabs_plotting "$out"

Thanks. I'll add a cc:stable to this, in an attempt to make older
kernels work well with newer toolchains.