2022-11-21 16:16:09

by Arthur Simchaev

Subject: [PATCH v3 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl

len argument is not used anymore in ufshcd_set_active_icc_lvl function.

Signed-off-by: Arthur Simchaev <[email protected]>
---
drivers/ufs/core/ufshcd.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 7456aa2..604348f 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -7391,12 +7391,11 @@ static u32 ufshcd_get_max_icc_level(int sup_curr_uA, u32 start_scan,
* In case regulators are not initialized we'll return 0
* @hba: per-adapter instance
* @desc_buf: power descriptor buffer to extract ICC levels from.
- * @len: length of desc_buff
*
* Returns calculated ICC level
*/
static u32 ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
- const u8 *desc_buf, int len)
+ const u8 *desc_buf)
{
u32 icc_level = 0;

@@ -7454,8 +7453,7 @@ static void ufshcd_set_active_icc_lvl(struct ufs_hba *hba)
goto out;
}

- icc_level = ufshcd_find_max_sup_active_icc_level(hba, desc_buf,
- QUERY_DESC_MAX_SIZE);
+ icc_level = ufshcd_find_max_sup_active_icc_level(hba, desc_buf);
dev_dbg(hba->dev, "%s: setting icc_level 0x%x", __func__, icc_level);

ret = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
--
2.7.4

2022-11-23 18:19:31

by Bean Huo

Subject: Re: [PATCH v3 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl

On Mon, 2022-11-21 at 17:46 +0200, Arthur Simchaev wrote:
> len argument is not used anymore in ufshcd_set_active_icc_lvl
> function.
>
> Signed-off-by: Arthur Simchaev <[email protected]>
> ---
> drivers/ufs/core/ufshcd.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 7456aa2..604348f 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -7391,12 +7391,11 @@ static u32 ufshcd_get_max_icc_level(int
> sup_curr_uA, u32 start_scan,
> * In case regulators are not initialized we'll return 0
> * @hba: per-adapter instance
> * @desc_buf: power descriptor buffer to extract ICC levels from.
> - * @len: length of desc_buff
> *
> * Returns calculated ICC level
> */
> static u32 ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
> - const u8 *desc_buf, int
> len)
> + const u8 *desc_buf)


The Linux kernel already deprecates the 80 character per line coding
style, so you could keep one line here after removing len.


Reviewed-by: Bean Huo <[email protected]>