2022-03-17 06:07:54

by baihaowen

[permalink] [raw]
Subject: [PATCH] macintosh: windfarm_pm91: Fix warning comparing pointer to 0

Avoid pointer type value compared with 0 to make code clear.

Signed-off-by: Haowen Bai <[email protected]>
---
drivers/macintosh/windfarm_pm91.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/macintosh/windfarm_pm91.c b/drivers/macintosh/windfarm_pm91.c
index 3f346af..568f8a2 100644
--- a/drivers/macintosh/windfarm_pm91.c
+++ b/drivers/macintosh/windfarm_pm91.c
@@ -149,7 +149,7 @@ static void wf_smu_create_cpu_fans(void)

/* First, locate the PID params in SMU SBD */
hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL);
- if (hdr == 0) {
+ if (!hdr) {
printk(KERN_WARNING "windfarm: CPU PID fan config not found "
"max fan speed\n");
goto fail;
--
2.7.4


2022-11-30 10:44:28

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH] macintosh: windfarm_pm91: Fix warning comparing pointer to 0

On Thu, 17 Mar 2022 10:42:33 +0800, Haowen Bai wrote:
> Avoid pointer type value compared with 0 to make code clear.
>
>

Applied to powerpc/next.

[1/1] macintosh: windfarm_pm91: Fix warning comparing pointer to 0
https://git.kernel.org/powerpc/c/88316944c3b3aa3ce3249c51689ef1621049df9d

cheers