2022-11-30 10:46:40

by Yang Yang

[permalink] [raw]
Subject: [PATCH] IB/hfi1: switch to netif_napi_add()

From: Yang Yang <[email protected]>

There is no need to use netif_napi_add_weight() when the weight argument
is 64. See "net: drop the weight argument from netif_napi_add".

Signed-off-by: Yang Yang <[email protected]>
Reviewed-by: xu xin <[email protected]>
Reviewed-by: Zhang Yunkai <[email protected]>
---
drivers/infiniband/hw/hfi1/netdev_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
index 3dfa5aff2512..08080ca6cb2d 100644
--- a/drivers/infiniband/hw/hfi1/netdev_rx.c
+++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
@@ -216,7 +216,7 @@ static int hfi1_netdev_rxq_init(struct hfi1_netdev_rx *rx)
* right now.
*/
set_bit(NAPI_STATE_NO_BUSY_POLL, &rxq->napi.state);
- netif_napi_add_weight(dev, &rxq->napi, hfi1_netdev_rx_napi, 64);
+ netif_napi_add(dev, &rxq->napi, hfi1_netdev_rx_napi);
rc = msix_netdev_request_rcd_irq(rxq->rcd);
if (rc)
goto bail_context_irq_failure;
--
2.15.2


2022-12-01 10:14:32

by Leon Romanovsky

[permalink] [raw]
Subject: Re: [PATCH] IB/hfi1: switch to netif_napi_add()

On Wed, 30 Nov 2022 17:44:37 +0800 (CST), [email protected] wrote:
> From: Yang Yang <[email protected]>
>
> There is no need to use netif_napi_add_weight() when the weight argument
> is 64. See "net: drop the weight argument from netif_napi_add".
>
>

Applied, thanks!

[1/1] IB/hfi1: switch to netif_napi_add()
https://git.kernel.org/rdma/rdma/c/10aa7cd398a9ea

Best regards,
--
Leon Romanovsky <[email protected]>