2022-12-01 12:31:26

by Yunfei Dong (董云飞)

[permalink] [raw]
Subject: [PATCH v3,2/3] media: dt-bindings: media: mediatek: vcodec: Change the max reg value to 2

From: Yunfei Dong <[email protected]>

Need to add racing control register base in device node for mt8195 support
inner racing mode. Changing the max reg value from 1 to 2.

Signed-off-by: Yunfei Dong <[email protected]>
---
.../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
index 09781ef02193..d20ef15147a4 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
@@ -61,7 +61,10 @@ properties:
- mediatek,mt8195-vcodec-dec

reg:
- maxItems: 1
+ minItems: 1
+ items:
+ - description: VDEC_SYS register space
+ - description: VDEC_RACING_CTRL register space

iommus:
minItems: 1
@@ -98,6 +101,7 @@ patternProperties:

reg:
maxItems: 1
+ description: VDEC_MISC register space

interrupts:
maxItems: 1
--
2.18.0


Subject: Re: [PATCH v3,2/3] media: dt-bindings: media: mediatek: vcodec: Change the max reg value to 2

Il 01/12/22 13:15, Yunfei Dong ha scritto:
> From: Yunfei Dong <[email protected]>
>
> Need to add racing control register base in device node for mt8195 support
> inner racing mode. Changing the max reg value from 1 to 2.
>
> Signed-off-by: Yunfei Dong <[email protected]>

You forgot to mention in the commit message that you're also adding a description
for the VDEC_MISC register space.

Please add that, after which:

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>


2022-12-02 00:18:59

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v3,2/3] media: dt-bindings: media: mediatek: vcodec: Change the max reg value to 2


On Thu, 01 Dec 2022 20:15:23 +0800, Yunfei Dong wrote:
> From: Yunfei Dong <[email protected]>
>
> Need to add racing control register base in device node for mt8195 support
> inner racing mode. Changing the max reg value from 1 to 2.
>
> Signed-off-by: Yunfei Dong <[email protected]>
> ---
> .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>

Acked-by: Rob Herring <[email protected]>