2022-12-02 16:00:29

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v6 0/3] arm64: dts: qcom: sm8450-hdk: add sound support

Hi,

Changes since v5
================
1. Patch 2:
- Use different clocks (codec@31e0000, codec@3240000).
- Order LPASS pinctrl nodes by GPIO number.
- Add dmic01-default-state and dmic02-default-state to LPASS pinctrl.
2. Patch 3:
- Use TX_CODEC_DMA_TX_3 for VA capture.
- Reverse order of speakers (left/right).
- Drop duplicated wcd-playback-dai-link and add wcd-capture-dai-link.

Changes since v4
================
1. Patch 2:
- Re-order few properties between Soundwire nodes, to keep them ordered
consistently.
- Drop unsupported qcom,port-offset.

Changes since v3
================
1. Re-order reg and sound-dai-cells.

Changes since v2
================
1. Patch 2: Use lower-case hex.
2. Patch 3: Use ACTIVE_LOW for qcom,wcd9380-codec reset-gpios.
https://lore.kernel.org/all/[email protected]
3. Add Rb tags.

Changes since v1
================
1. Patch 2:
- Whitespace cleanups.
- Correct include - do not use deprecated one.
2. Patch 3:
- Sort.
- Add Rb tag.
- Correct include - do not use deprecated one and drop q6asm.h (not used).

Description
===========
Initial work (still partially in progress) adding audio to HDK8450 board.

Working/tested:
- speakers
- one channel of headset

The DTS patches do not have particular dependencies, however they:
1. Use updated ASoC bindings:
https://lore.kernel.org/linux-arm-msm/[email protected]/T/#t

2. For full operation need changes in Soundwire and Qualcomm ASoC drivers, not
yet upstreamed:
https://github.com/krzk/linux/commits/wip/sm8450
Booting remoteproc without these changes will report errors, but these are
expected at this stage.

Best regards,
Krzysztof

Cc: Srinivas Kandagatla <[email protected]>

Srinivas Kandagatla (3):
arm64: dts: qcom: sm8450: add GPR node
arm64: dts: qcom: sm8450: add Soundwire and LPASS
arm64: dts: qcom: sm8450-hdk: add sound support

arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 186 ++++++++++++
arch/arm64/boot/dts/qcom/sm8450.dtsi | 364 ++++++++++++++++++++++++
2 files changed, 550 insertions(+)

--
2.34.1


2022-12-06 18:40:04

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v6 0/3] arm64: dts: qcom: sm8450-hdk: add sound support

On Fri, 2 Dec 2022 16:20:51 +0100, Krzysztof Kozlowski wrote:
> Changes since v5
> ================
> 1. Patch 2:
> - Use different clocks (codec@31e0000, codec@3240000).
> - Order LPASS pinctrl nodes by GPIO number.
> - Add dmic01-default-state and dmic02-default-state to LPASS pinctrl.
> 2. Patch 3:
> - Use TX_CODEC_DMA_TX_3 for VA capture.
> - Reverse order of speakers (left/right).
> - Drop duplicated wcd-playback-dai-link and add wcd-capture-dai-link.
>
> [...]

Applied, thanks!

[1/3] arm64: dts: qcom: sm8450: add GPR node
commit: 38463210a9cb9eb03431c6c610ad3b66df3afc6c
[2/3] arm64: dts: qcom: sm8450: add Soundwire and LPASS
commit: 14341e76dbc7e10c9bf19f4c214161dc3030ca3d
[3/3] arm64: dts: qcom: sm8450-hdk: add sound support
commit: 2dcd495f15cbf330aa68dc074f0eb0aeaff4eead

Best regards,
--
Bjorn Andersson <[email protected]>