2022-12-21 10:27:33

by Srinivasa Rao Mandadapu

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: clock: SC7280: Add resets for LPASS audio clock controller

Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks
for audioreach based SC7280 platforms.

Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
---
Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml
index 6151fde..b9be5f1 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml
@@ -31,6 +31,9 @@ properties:
'#clock-cells':
const: 1

+ '#reset-cells':
+ const: 1
+
reg:
items:
- description: LPASS qdsp6ss register
@@ -61,5 +64,6 @@ examples:
clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
clock-names = "iface";
#clock-cells = <1>;
+ #reset-cells = <1>;
};
...
--
2.7.4


2022-12-21 10:51:12

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: clock: SC7280: Add resets for LPASS audio clock controller

On 21/12/2022 11:21, Srinivasa Rao Mandadapu wrote:
> Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks
> for audioreach based SC7280 platforms.

Use subject prefixes matching the subsystem (git log --oneline -- ...).
The final prefix should be "qcom,sc7280-lpasscc" and then the actual
subject should drop redundant pieces.

> ...

Best regards,
Krzysztof

2022-12-21 13:28:17

by Srinivasa Rao Mandadapu

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: clock: SC7280: Add resets for LPASS audio clock controller


On 12/21/2022 4:12 PM, Krzysztof Kozlowski wrote:
Thanks for your time Krzyszto!!!
> On 21/12/2022 11:21, Srinivasa Rao Mandadapu wrote:
>> Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks
>> for audioreach based SC7280 platforms.
> Use subject prefixes matching the subsystem (git log --oneline -- ...).
> The final prefix should be "qcom,sc7280-lpasscc" and then the actual
> subject should drop redundant pieces.

Sorry. I didn't understand much from your statement.

Do you mean subject should something like below?

 dt-bindings: clock: qcom: sc7280-lpasscc: Add resets for audio clock
controller

>
>> ...
> Best regards,
> Krzysztof
>