2022-12-10 11:58:22

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address

By coding style, unit address should not start with 0x.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 1a257f672887..a63dbd12230f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -1636,7 +1636,7 @@ uart7: serial@89c000 {
};
};

- gpi_dma1: dma-controller@0xa00000 {
+ gpi_dma1: dma-controller@a00000 {
#dma-cells = <3>;
compatible = "qcom,sdm845-gpi-dma";
reg = <0 0x00a00000 0 0x60000>;
--
2.34.1


2022-12-10 13:01:19

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address



On 10.12.2022 12:33, Krzysztof Kozlowski wrote:
> By coding style, unit address should not start with 0x.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
We somehow keep running into solving the same style issues :P

https://lore.kernel.org/lkml/[email protected]/

Konrad
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 1a257f672887..a63dbd12230f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -1636,7 +1636,7 @@ uart7: serial@89c000 {
> };
> };
>
> - gpi_dma1: dma-controller@0xa00000 {
> + gpi_dma1: dma-controller@a00000 {
> #dma-cells = <3>;
> compatible = "qcom,sdm845-gpi-dma";
> reg = <0 0x00a00000 0 0x60000>;

2022-12-11 20:36:23

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address

On 10/12/2022 13:26, Konrad Dybcio wrote:
>
>
> On 10.12.2022 12:33, Krzysztof Kozlowski wrote:
>> By coding style, unit address should not start with 0x.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
> We somehow keep running into solving the same style issues :P
>
> https://lore.kernel.org/lkml/[email protected]/
>

Eh, this should have been just applied long time ago...

Best regards,
Krzysztof

2022-12-28 04:17:25

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address

On Sun, Dec 11, 2022 at 09:15:36PM +0100, Krzysztof Kozlowski wrote:
> On 10/12/2022 13:26, Konrad Dybcio wrote:
> >
> >
> > On 10.12.2022 12:33, Krzysztof Kozlowski wrote:
> >> By coding style, unit address should not start with 0x.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> >> ---
> > We somehow keep running into solving the same style issues :P
> >
> > https://lore.kernel.org/lkml/[email protected]/
> >
>
> Eh, this should have been just applied long time ago...
>

That's patch 7 in a series, which I would be expecting to see respun
per your request for changes.


@Konrad, please put fixes like that first in your series - or just send
them separate from the series.

Regards,
Bjorn

2022-12-28 05:06:23

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address

On Sat, 10 Dec 2022 12:33:40 +0100, Krzysztof Kozlowski wrote:
> By coding style, unit address should not start with 0x.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sdm845: drop 0x from unit address
commit: 1629063ec9d8a32111a63ce7250a7781376c492a

Best regards,
--
Bjorn Andersson <[email protected]>