2022-12-10 10:52:14

by Konrad Dybcio

Subject: [PATCH] arm64: dts: qcom: sm6350: Fix up the ramoops node

Fix up the ramoops node to make it match bindings and style:

- remove "removed-dma-pool"
- don't pad size to 8 hex digits
- change cc-size to ecc-size so that it's used
- increase ecc-size from to 16
- remove the zeroed ftrace-size

Fixes: 5f82b9cda61e ("arm64: dts: qcom: Add SM6350 device tree")
Reported-by: Luca Weiss <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/sm6350.dtsi | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
index 567f4893c562..b8e03efc44a7 100644
--- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
@@ -344,13 +344,12 @@ last_log_region: memory@ffbc0000 {
};

ramoops: ramoops@ffc00000 {
- compatible = "removed-dma-pool", "ramoops";
- reg = <0 0xffc00000 0 0x00100000>;
+ compatible = "ramoops";
+ reg = <0 0xffc00000 0 0x100000>;
record-size = <0x1000>;
console-size = <0x40000>;
- ftrace-size = <0x0>;
msg-size = <0x20000 0x20000>;
- cc-size = <0x0>;
+ ecc-size = <16>;
no-map;
};

--
2.38.1

2022-12-28 04:58:20

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sm6350: Fix up the ramoops node

On Sat, 10 Dec 2022 11:25:59 +0100, Konrad Dybcio wrote:
> Fix up the ramoops node to make it match bindings and style:
>
> - remove "removed-dma-pool"
> - don't pad size to 8 hex digits
> - change cc-size to ecc-size so that it's used
> - increase ecc-size from to 16
> - remove the zeroed ftrace-size
>
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sm6350: Fix up the ramoops node
commit: 3b2ff50da499178cc418f4b319e279d1b52958ed

Best regards,
--
Bjorn Andersson <[email protected]>