2022-12-10 16:19:47

by Konrad Dybcio

Subject: [PATCH 1/2] arm64: dts: qcom: msm8996-tone: Enable SDHCI1

With the recent patch that allowed us to reset the SDHCI controller from
Linux, things started working properly. Enable SDHCI1, and by extension
eMMC. Also, remove the now-useless cmdline SDHCI quirks.

Signed-off-by: Konrad Dybcio <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
index dec361b93cce..c9be32b81d36 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi
@@ -24,11 +24,7 @@ / {
qcom,board-id = <8 0>;

chosen {
- /*
- * Due to an unknown-for-a-few-years regression,
- * SDHCI only works on MSM8996 in PIO (lame) mode.
- */
- bootargs = "sdhci.debug_quirks=0x40 sdhci.debug_quirks2=0x4 maxcpus=2";
+ bootargs = "maxcpus=2";
};

reserved-memory {
@@ -825,8 +821,7 @@ pm8994_l32: l32 {
};

&sdhc1 {
- /* eMMC doesn't seem to cooperate even in PIO mode.. */
- status = "disabled";
+ status = "okay";

vmmc-supply = <&pm8994_l20>;
vqmmc-supply = <&pm8994_s4>;
--
2.38.1

2022-12-28 04:40:06

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/2] arm64: dts: qcom: msm8996-tone: Enable SDHCI1

On Sat, 10 Dec 2022 15:09:59 +0100, Konrad Dybcio wrote:
> With the recent patch that allowed us to reset the SDHCI controller from
> Linux, things started working properly. Enable SDHCI1, and by extension
> eMMC. Also, remove the now-useless cmdline SDHCI quirks.
>
>

Applied, thanks!

[1/2] arm64: dts: qcom: msm8996-tone: Enable SDHCI1
commit: b860ba9e42538f2a490925121071c215c23d1863
[2/2] arm64: dts: qcom: msm8996-tone: Move status last
commit: 6152ab29a39131328a310b578aae693d3ec74a9d

Best regards,
--
Bjorn Andersson <[email protected]>