2022-08-18 22:06:13

by Wolfram Sang

Subject: [PATCH] rpmsg: move from strlcpy with unused retval to strscpy

Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang <[email protected]>
---
drivers/rpmsg/qcom_glink_ssr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg/qcom_glink_ssr.c
index 776d64446879..39ffa384c9b1 100644
--- a/drivers/rpmsg/qcom_glink_ssr.c
+++ b/drivers/rpmsg/qcom_glink_ssr.c
@@ -111,7 +111,7 @@ static int qcom_glink_ssr_notifier_call(struct notifier_block *nb,
msg.command = cpu_to_le32(GLINK_SSR_DO_CLEANUP);
msg.seq_num = cpu_to_le32(ssr->seq_num);
msg.name_len = cpu_to_le32(strlen(ssr_name));
- strlcpy(msg.name, ssr_name, sizeof(msg.name));
+ strscpy(msg.name, ssr_name, sizeof(msg.name));

ret = rpmsg_send(ssr->ept, &msg, sizeof(msg));
if (ret < 0)
--
2.35.1

2022-12-28 18:53:23

by Bjorn Andersson

Subject: Re: [PATCH] rpmsg: move from strlcpy with unused retval to strscpy

On Thu, 18 Aug 2022 23:01:00 +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
>

Applied, thanks!

[1/1] rpmsg: move from strlcpy with unused retval to strscpy
commit: d2ff0f84c1156dfd3646a4ca682b38413b409aa0

Best regards,
--
Bjorn Andersson <[email protected]>