2023-01-06 08:09:58

by Srinivasa Rao Mandadapu

Subject: [PATCH v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names

Add reg-names and power-domain-names for remoteproc ADSP pheripheral
loader. This is to make compatible with remoteproc ADSP PIL driver.
Also change power domain from LCX to CX.

Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
---
Changes Since v1:
-- Modify subject line to SoC specific.

.../devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
index 94ca7a0..b5bee2c 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
@@ -23,6 +23,11 @@ properties:
- description: qdsp6ss register
- description: efuse q6ss register

+ reg-names:
+ items:
+ - const: qdsp6ss_base
+ - const: lpass_efuse
+
iommus:
items:
- description: Phandle to apps_smmu node with sid mask
@@ -57,7 +62,11 @@ properties:

power-domains:
items:
- - description: LCX power domain
+ - description: CX power domain
+
+ power-domain-names:
+ items:
+ - const: cx

resets:
items:
--
2.7.4

2023-01-08 15:43:05

by Krzysztof Kozlowski

Subject: Re: [PATCH v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names

On 06/01/2023 08:50, Srinivasa Rao Mandadapu wrote:
> Add reg-names and power-domain-names for remoteproc ADSP pheripheral
> loader. This is to make compatible with remoteproc ADSP PIL driver.

I don't understand the reasoning. Before binding was "incompatible"?

> Also change power domain from LCX to CX.

Why? Hardware changed?

>
> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> ---
> Changes Since v1:
> -- Modify subject line to SoC specific.
>
> .../devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
> index 94ca7a0..b5bee2c 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
> @@ -23,6 +23,11 @@ properties:
> - description: qdsp6ss register
> - description: efuse q6ss register
>
> + reg-names:
> + items:
> + - const: qdsp6ss_base
> + - const: lpass_efuse
> +
> iommus:
> items:
> - description: Phandle to apps_smmu node with sid mask
> @@ -57,7 +62,11 @@ properties:
>
> power-domains:
> items:
> - - description: LCX power domain
> + - description: CX power domain
> +
> + power-domain-names:
> + items:
> + - const: cx
>
> resets:
> items:

Best regards,
Krzysztof

2023-01-10 07:10:24

by Srinivasa Rao Mandadapu

Subject: Re: [PATCH v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names

On 1/8/2023 9:06 PM, Krzysztof Kozlowski wrote:
Thanks for Your Time Krzyszto!!!
> On 06/01/2023 08:50, Srinivasa Rao Mandadapu wrote:
>> Add reg-names and power-domain-names for remoteproc ADSP pheripheral
>> loader. This is to make compatible with remoteproc ADSP PIL driver.
> I don't understand the reasoning. Before binding was "incompatible"?

Yes. Previous bindings needs fixes. Will add fixes tag for the same. So
far corresponding device tree not

mainlined and no user till now, hence these missing errors not found.

>
>> Also change power domain from LCX to CX.
> Why? Hardware changed?

No, basically it's a fix. The power domain name wrongly mentioned in
previous bindings.

The fixes tag mentioned above will be applicable here also.

>
>> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
>> ---
>> Changes Since v1:
>> -- Modify subject line to SoC specific.
>>
>> .../devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml | 11 ++++++++++-
>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
>> index 94ca7a0..b5bee2c 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
>> @@ -23,6 +23,11 @@ properties:
>> - description: qdsp6ss register
>> - description: efuse q6ss register
>>
>> + reg-names:
>> + items:
>> + - const: qdsp6ss_base
>> + - const: lpass_efuse
>> +
>> iommus:
>> items:
>> - description: Phandle to apps_smmu node with sid mask
>> @@ -57,7 +62,11 @@ properties:
>>
>> power-domains:
>> items:
>> - - description: LCX power domain
>> + - description: CX power domain
>> +
>> + power-domain-names:
>> + items:
>> + - const: cx
>>
>> resets:
>> items:
> Best regards,
> Krzysztof
>