2022-12-21 13:11:45

by Chao Yu

Subject: [PATCH] f2fs: fix to call clear_page_private_reference in .{release,invalid}_folio

b763f3bedc2d ("f2fs: restructure f2fs page.private layout") missed
to call clear_page_private_reference() in .{release,invalid}_folio,
fix it, though it's not a big deal since folio_detach_private() was
called to clear all privae info and reference count in the page.

BTW, remove page_private_reference() definition as it never be used.

Signed-off-by: Chao Yu <[email protected]>
---
fs/f2fs/data.c | 2 ++
fs/f2fs/f2fs.h | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index b1ec0fbf1c8f..53d8945df2c1 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -3696,6 +3696,7 @@ void f2fs_invalidate_folio(struct folio *folio, size_t offset, size_t length)
}
}

+ clear_page_private_reference(&folio->page);
clear_page_private_gcing(&folio->page);

if (test_opt(sbi, COMPRESS_CACHE) &&
@@ -3721,6 +3722,7 @@ bool f2fs_release_folio(struct folio *folio, gfp_t wait)
clear_page_private_data(&folio->page);
}

+ clear_page_private_reference(&folio->page);
clear_page_private_gcing(&folio->page);

folio_detach_private(folio);
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 9da26d4ec017..049d4fa0b59e 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -1453,7 +1453,6 @@ static inline void clear_page_private_##name(struct page *page) \
}

PAGE_PRIVATE_GET_FUNC(nonpointer, NOT_POINTER);
-PAGE_PRIVATE_GET_FUNC(reference, REF_RESOURCE);
PAGE_PRIVATE_GET_FUNC(inline, INLINE_INODE);
PAGE_PRIVATE_GET_FUNC(gcing, ONGOING_MIGRATION);
PAGE_PRIVATE_GET_FUNC(dummy, DUMMY_WRITE);
--
2.36.1

2023-01-09 23:36:42

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to call clear_page_private_reference in .{release, invalid}_folio

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Wed, 21 Dec 2022 20:13:45 +0800 you wrote:
> b763f3bedc2d ("f2fs: restructure f2fs page.private layout") missed
> to call clear_page_private_reference() in .{release,invalid}_folio,
> fix it, though it's not a big deal since folio_detach_private() was
> called to clear all privae info and reference count in the page.
>
> BTW, remove page_private_reference() definition as it never be used.
>
> [...]

Here is the summary with links:
- [f2fs-dev] f2fs: fix to call clear_page_private_reference in .{release, invalid}_folio
https://git.kernel.org/jaegeuk/f2fs/c/6779b5db90c5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html