2017-10-31 18:09:34

by Madhani, Himanshu

[permalink] [raw]
Subject: Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Martin/Kees,

> On Oct 31, 2017, at 8:49 AM, Martin K. Petersen <[email protected]> wrote:
>
>
> Kees,
>
>> In preparation for unconditionally passing the struct timer_list
>> pointer to all timer callbacks, switch to using the new timer_setup()
>> and from_timer() to pass the timer pointer explicitly.
>
> Cavium folks: Please verify!
>

I’ve checked on my setup and i am seeing regression with this patch applied.

Driver load locks up the system with this patch applied.

NACK

> Reviewed-by: Martin K. Petersen <[email protected]>
>
> --
> Martin K. Petersen Oracle Linux Engineering

Thanks,
- Himanshu

?&ן6??<?}:??|????S?㜷}u??t??>?M4?M{_???1? ???Ͷ?5??u??=?U?f????m?l??ۣ?jנ??????