2022-12-13 13:52:06

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments

As much as it hurts me, there is no FM radio chips on these devices.
It seems to be present on Japanese models, but these are not available
globally and differ in a few more ways anyway (such as a super high-tech
NFC chip).

Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
index fdfed4c3201e..bf484ee20b21 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
@@ -529,10 +529,8 @@ &i2c15 {
clock-frequency = <400000>;

/* Qcom SMB1390 @ 10 */
- /* Silicon Labs SI4704 FM Radio Receiver @ 11 */
/* Qcom SMB1390_slave @ 18 */
/* HALO HL6111R Qi charger @ 25 */
- /* Richwave RTC6226 FM Radio Receiver @ 64 */
};

&pcie0 {
--
2.39.0


2022-12-13 14:48:20

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 2/3] arm64: dts: qcom: sm8350-sagami: Disable empty i2c bus

As much as it hurts me, there is no FM radio chips on these devices.
It seems to be present on Japanese models, but these are not available
globally and differ in a few more ways anyway (such as a super high-tech
NFC chip). Since it's the only subdevice of its I2C host bus, disable
said bus to save some power.

Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi | 7 -------
1 file changed, 7 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
index 2f727e4f2e57..c63f813d6d5b 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
@@ -472,13 +472,6 @@ &i2c1 {
/* Some subset of SONY IMX663 camera sensor @ 38 */
};

-&i2c2 {
- status = "okay";
- clock-frequency = <400000>;
-
- /* Richwave RTC6226 FM Radio Receiver @ 64 */
-};
-
&i2c4 {
status = "okay";
clock-frequency = <400000>;
--
2.39.0

2023-01-11 05:38:29

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments

On Tue, 13 Dec 2022 14:25:15 +0100, Konrad Dybcio wrote:
> As much as it hurts me, there is no FM radio chips on these devices.
> It seems to be present on Japanese models, but these are not available
> globally and differ in a few more ways anyway (such as a super high-tech
> NFC chip).
>
>

Applied, thanks!

[1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments
commit: 2a87b555553e357460da6f3cbc95bd6eadc852c0
[2/3] arm64: dts: qcom: sm8350-sagami: Disable empty i2c bus
commit: 71b4fb83a958881666f52d6275cd264ec909c7bc
[3/3] arm64: dts: qcom: sm8450-nagara: Disable empty i2c bus
commit: 7ca5618520c6c8fd1419e2b057681d4f1d7b6578

Best regards,
--
Bjorn Andersson <[email protected]>