2023-01-07 14:05:20

by Lin, Meng-Bo

Subject: [PATCH v6 0/5] arm64: dts: qcom: msm8916-gplus-fl8005a: Add initial device tree

v6: Sort pinctrl properties and remove stray newlines in pinctrl.
v5: Reword the flash LEDs patch.
v4: Fix missing Makefile entry in v3.
v3: Sort properties in l11 and nodes in touchscreen pinctrl.
v2: Set property status = "okay"; as the last property.
Reword the bindings patch.

GPLUS FL8005A is a tablet using the MSM8916 SoC released in 2015.

Add a device tree for with initial support for:

- GPIO keys
- GPIO LEDs
- pm8916-vibrator
- SDHCI (internal and external storage)
- USB Device Mode
- UART
- WCNSS (WiFi/BT)
- Regulators
- Focaltech FT5402 touchscreen
- Qualcomm GPIO flash LEDs

2023-01-07 14:20:19

by Lin, Meng-Bo

Subject: [PATCH v6 5/5] arm64: dts: qcom: msm8916-gplus-fl8005a: Add flash LED

FL8005A uses Qualcomm GPIO flash LEDs which is compatible with
SGM3140 Flash LED driver. Add it to the device tree.

Signed-off-by: Lin, Meng-Bo <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>
---
.../boot/dts/qcom/msm8916-gplus-fl8005a.dts | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts b/arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts
index b44c30a72784..a0e520edde02 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts
@@ -21,6 +21,22 @@ chosen {
stdout-path = "serial0";
};

+ flash-led-controller {
+ /* Actually qcom,leds-gpio-flash */
+ compatible = "sgmicro,sgm3140";
+ enable-gpios = <&msmgpio 31 GPIO_ACTIVE_HIGH>;
+ flash-gpios = <&msmgpio 32 GPIO_ACTIVE_HIGH>;
+
+ pinctrl-0 = <&camera_flash_default>;
+ pinctrl-names = "default";
+
+ flash_led: led {
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ flash-max-timeout-us = <250000>;
+ };
+ };
+
gpio-keys {
compatible = "gpio-keys";

@@ -237,6 +253,13 @@ l18 {
};

&msmgpio {
+ camera_flash_default: camera-flash-default-state {
+ pins = "gpio31", "gpio32";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
gpio_keys_default: gpio-keys-default-state {
pins = "gpio107";
function = "gpio";
--
2.30.2

2023-01-11 19:55:12

by Bjorn Andersson

Subject: Re: (subset) [PATCH v6 0/5] arm64: dts: qcom: msm8916-gplus-fl8005a: Add initial device tree

On Sat, 07 Jan 2023 13:31:30 +0000, Lin, Meng-Bo wrote:
> v6: Sort pinctrl properties and remove stray newlines in pinctrl.
> v5: Reword the flash LEDs patch.
> v4: Fix missing Makefile entry in v3.
> v3: Sort properties in l11 and nodes in touchscreen pinctrl.
> v2: Set property status = "okay"; as the last property.
> Reword the bindings patch.
>
> [...]

Applied, thanks!

[3/5] arm64: dts: qcom: msm8916-gplus-fl8005a: Add initial device tree
commit: 662a90c4e72579967cb682fb6b4c6f061cc00ab9
[4/5] arm64: dts: qcom: msm8916-gplus-fl8005a: Add touchscreen
commit: 143b4b845f58380a334cc0b9242567e602233743
[5/5] arm64: dts: qcom: msm8916-gplus-fl8005a: Add flash LED
commit: 599a259a4b3b6c0d4c4b51d9e58408ac6de779f0

Best regards,
--
Bjorn Andersson <[email protected]>