2022-12-31 00:41:02

by Alex Elder

[permalink] [raw]
Subject: [PATCH 0/2] dts: qcom: use "qcom,gsi-loader"

IPA hardware has a GSI component that needs firmware loaded.
Recently, the way to specify how this firmware is loaded has
been changed. As a result, indicating this via the presence or
absence of a "modem-init" property is now deprecated. Instead,
a new "qcom,gsi-loader" property is used; this permits a third
method of loading GSI firmware to be supported.
https://lore.kernel.org/netdev/[email protected]/

This series updates all of the exiting ARM and arm64 DTS files for
platforms implementing IPA so they specify the GSI loader using the
new property.

-Alex

Alex Elder (2):
ARM: dts: qcom: use qcom,gsi-loader for IPA
arm64: dts: qcom: use qcom,gsi-loader for IPA

arch/arm/boot/dts/qcom-sdx55-t55.dts | 4 ++--
arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 4 ++--
arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi | 5 ++---
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 3 ++-
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 ++--
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 4 ++--
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 3 ++-
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 1 +
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 3 ++-
arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts | 3 ++-
arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8350-mtp.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi | 3 ++-
17 files changed, 29 insertions(+), 24 deletions(-)

--
2.34.1


2022-12-31 00:56:23

by Alex Elder

[permalink] [raw]
Subject: [PATCH 1/2] ARM: dts: qcom: use qcom,gsi-loader for IPA

Depending on the platform, either the modem or the AP must load GSI
firmware for IPA before it can be used. To date, this has been
indicated by the presence or absence of a "modem-init" property.

That mechanism has been deprecated. Instead, we indicate how GSI
firmware should be loaded by the value of the "qcom,gsi-loader"
property.

Update all ARM platforms that use IPA to use the "qcom,gsi-loader"
property to specify how the GSI firmware is loaded.

Update the affected nodes so the status property is last.

Signed-off-by: Alex Elder <[email protected]>
---
arch/arm/boot/dts/qcom-sdx55-t55.dts | 4 ++--
arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-sdx55-t55.dts b/arch/arm/boot/dts/qcom-sdx55-t55.dts
index 7ed8feb99afbe..61ac5f54cd57d 100644
--- a/arch/arm/boot/dts/qcom-sdx55-t55.dts
+++ b/arch/arm/boot/dts/qcom-sdx55-t55.dts
@@ -237,9 +237,9 @@ &blsp1_uart3 {
};

&ipa {
- status = "okay";
-
+ qcom,gsi-loader = "self";
memory-region = <&ipa_fw_mem>;
+ status = "okay";
};

&qpic_bam {
diff --git a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
index ac8b4626ae9ac..c9c1f7da1261b 100644
--- a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
+++ b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
@@ -237,9 +237,9 @@ &blsp1_uart3 {
};

&ipa {
- status = "okay";
-
+ qcom,gsi-loader = "self";
memory-region = <&ipa_fw_mem>;
+ status = "okay";
};

&pcie0_phy {
--
2.34.1

2022-12-31 12:26:29

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 1/2] ARM: dts: qcom: use qcom,gsi-loader for IPA



On 31.12.2022 01:27, Alex Elder wrote:
> Depending on the platform, either the modem or the AP must load GSI
> firmware for IPA before it can be used. To date, this has been
> indicated by the presence or absence of a "modem-init" property.
>
> That mechanism has been deprecated. Instead, we indicate how GSI
> firmware should be loaded by the value of the "qcom,gsi-loader"
> property.
>
> Update all ARM platforms that use IPA to use the "qcom,gsi-loader"
> property to specify how the GSI firmware is loaded.
>
> Update the affected nodes so the status property is last.
>
> Signed-off-by: Alex Elder <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm/boot/dts/qcom-sdx55-t55.dts | 4 ++--
> arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-sdx55-t55.dts b/arch/arm/boot/dts/qcom-sdx55-t55.dts
> index 7ed8feb99afbe..61ac5f54cd57d 100644
> --- a/arch/arm/boot/dts/qcom-sdx55-t55.dts
> +++ b/arch/arm/boot/dts/qcom-sdx55-t55.dts
> @@ -237,9 +237,9 @@ &blsp1_uart3 {
> };
>
> &ipa {
> - status = "okay";
> -
> + qcom,gsi-loader = "self";
> memory-region = <&ipa_fw_mem>;
> + status = "okay";
> };
>
> &qpic_bam {
> diff --git a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> index ac8b4626ae9ac..c9c1f7da1261b 100644
> --- a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> +++ b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> @@ -237,9 +237,9 @@ &blsp1_uart3 {
> };
>
> &ipa {
> - status = "okay";
> -
> + qcom,gsi-loader = "self";
> memory-region = <&ipa_fw_mem>;
> + status = "okay";
> };
>
> &pcie0_phy {

2023-01-18 23:59:05

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 0/2] dts: qcom: use "qcom,gsi-loader"

On Fri, 30 Dec 2022 18:27:14 -0600, Alex Elder wrote:
> IPA hardware has a GSI component that needs firmware loaded.
> Recently, the way to specify how this firmware is loaded has
> been changed. As a result, indicating this via the presence or
> absence of a "modem-init" property is now deprecated. Instead,
> a new "qcom,gsi-loader" property is used; this permits a third
> method of loading GSI firmware to be supported.
> https://lore.kernel.org/netdev/[email protected]/
>
> [...]

Applied, thanks!

[1/2] ARM: dts: qcom: use qcom,gsi-loader for IPA
commit: cbf91f46a72a0a1f8d2517c166101c4c85a0b940

Best regards,
--
Bjorn Andersson <[email protected]>