2023-01-19 01:56:17

by Byungchul Park

[permalink] [raw]
Subject: Re: [PATCH RFC v7 08/23] dept: Apply sdt_might_sleep_strong() to PG_{locked,writeback} wait

Hillf wrote:
> On 9 Jan 2023 12:33:36 +0900 Byungchul Park <[email protected]>
>> Makes Dept able to track dependencies by PG_{locked,writeback} waits.
>>
>> Signed-off-by: Byungchul Park <[email protected]>
>> ---
>
> Hey Byungchul

+cc [email protected]

Hi,

This email never reached to me.

> Is DEPT able to get deadlock reported for the syzbot report [1]?

DEPT can detect the case 100% *IF* the folio_trylock() is released
within the same context since DEPT tracks folio_trylock(), folio_lock()
and folio_unlock(), and it's definitely a deadlock.

But as we know, because folio_trylock() can be released by another
context like irq, it might be either just a severe slowdown of the
context triggering folio_unlock() or a literal deadlock where the
context is involved. I dunno which one is the case.

In short, DEPT can detect this case too *IF* it's a literal deadlock,
but it doesn't if it's just a slowdown. I'm planning to warn it even if
there is a slowdown tho, not for now.

Let me reproduce the following issue. I will share the result.

> Hillf
>
> [1] https://lore.kernel.org/lkml/[email protected]/

Byungchul


2023-01-21 03:39:25

by Byungchul Park

[permalink] [raw]
Subject: Re: [PATCH RFC v7 08/23] dept: Apply sdt_might_sleep_strong() to PG_{locked,writeback} wait

Byungchul wrote:
> Hillf wrote:
> > On 9 Jan 2023 12:33:36 +0900 Byungchul Park <[email protected]>
> > > Makes Dept able to track dependencies by PG_{locked,writeback} waits.
> > >
> > > Signed-off-by: Byungchul Park <[email protected]>
> > > ---
> >
> > Hey Byungchul
>
> +cc [email protected]
>
> Hi,
>
> This email never reached to me.
>
> > Is DEPT able to get deadlock reported for the syzbot report [1]?
>
> DEPT can detect the case 100% *IF* the folio_trylock() is released
> within the same context since DEPT tracks folio_trylock(), folio_lock()
> and folio_unlock(), and it's definitely a deadlock.
>
> But as we know, because folio_trylock() can be released by another
> context like irq, it might be either just a severe slowdown of the
> context triggering folio_unlock() or a literal deadlock where the
> context is involved. I dunno which one is the case.
>
> In short, DEPT can detect this case too *IF* it's a literal deadlock,
> but it doesn't if it's just a slowdown. I'm planning to warn it even if
> there is a slowdown tho, not for now.
>
> Let me reproduce the following issue. I will share the result.

Hi Hillf,

Can we talk about the DEPT report for the hang issue in here?

https://lore.kernel.org/lkml/[email protected]/T/#m458f4d5f3da06a28c7fbb39b392d05e4c016603b

Thanks,
Byungchul

> > Hillf
> >
> > [1] https://lore.kernel.org/lkml/[email protected]/
>
> Byungchul
>