2023-01-09 11:36:55

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 1/4] ARM: dts: qcom: align OPP table node name with DT schema

Bindings expect OPP tables to start with "opp-table".

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>

---

Changes since v1:
1. Add tags.
2. Re-order nodes
---
arch/arm/boot/dts/qcom-sdx55.dtsi | 14 +++++++-------
arch/arm/boot/dts/qcom-sdx65.dtsi | 26 +++++++++++++-------------
2 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 5408ff715fbf..a9433d1e4f54 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -62,7 +62,13 @@ cpu0: cpu@0 {
};
};

- cpu_opp_table: cpu-opp-table {
+ firmware {
+ scm {
+ compatible = "qcom,scm-sdx55", "qcom,scm";
+ };
+ };
+
+ cpu_opp_table: opp-table-cpu {
compatible = "operating-points-v2";
opp-shared;

@@ -87,12 +93,6 @@ opp-1555200000 {
};
};

- firmware {
- scm {
- compatible = "qcom,scm-sdx55", "qcom,scm";
- };
- };
-
psci {
compatible = "arm,psci-1.0";
method = "smc";
diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
index d3c661d7650d..619cafb6d9b3 100644
--- a/arch/arm/boot/dts/qcom-sdx65.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
@@ -61,7 +61,19 @@ cpu0: cpu@0 {
};
};

- cpu_opp_table: cpu-opp-table {
+ firmware {
+ scm {
+ compatible = "qcom,scm-sdx65", "qcom,scm";
+ };
+ };
+
+ mc_virt: interconnect-mc-virt {
+ compatible = "qcom,sdx65-mc-virt";
+ #interconnect-cells = <1>;
+ qcom,bcm-voters = <&apps_bcm_voter>;
+ };
+
+ cpu_opp_table: opp-table-cpu {
compatible = "operating-points-v2";
opp-shared;

@@ -86,18 +98,6 @@ opp-1497600000 {
};
};

- firmware {
- scm {
- compatible = "qcom,scm-sdx65", "qcom,scm";
- };
- };
-
- mc_virt: interconnect-mc-virt {
- compatible = "qcom,sdx65-mc-virt";
- #interconnect-cells = <1>;
- qcom,bcm-voters = <&apps_bcm_voter>;
- };
-
psci {
compatible = "arm,psci-1.0";
method = "smc";
--
2.34.1


2023-01-09 11:38:56

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 3/4] arm64: dts: qcom: sm8250: drop unused clock-frequency from wsa-macro

Neither qcom,sm8250-lpass-wsa-macro bindings nor the driver use
"clock-frequency" property.

sm8250-hdk.dtb: codec@3240000: Unevaluated properties are not allowed ('clock-frequency' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>

---

Changes since v1:
1. Add tags.
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 434e2c4cce79..a58f51083715 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2215,7 +2215,6 @@ wsamacro: codec@3240000 {
clock-names = "mclk", "npl", "macro", "dcodec", "va", "fsgen";

#clock-cells = <0>;
- clock-frequency = <9600000>;
clock-output-names = "mclk";
#sound-dai-cells = <1>;

--
2.34.1

2023-01-09 11:43:15

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 4/4] arm64: dts: qcom: sm8250: drop unused properties from tx-macro

Neither qcom,sm8250-lpass-tx-macro bindings nor the driver use
"clock-frequency" and address/size cells properties.

sm8250-mtp.dtb: txmacro@3220000: Unevaluated properties are not allowed ('clock-frequency', '#address-cells', '#size-cells' were unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>

---

Changes since v1:
1. Add tags.
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index a58f51083715..ddd750591e8c 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2329,10 +2329,7 @@ txmacro: txmacro@3220000 {
clock-names = "mclk", "npl", "macro", "dcodec", "fsgen";

#clock-cells = <0>;
- clock-frequency = <9600000>;
clock-output-names = "mclk";
- #address-cells = <2>;
- #size-cells = <2>;
#sound-dai-cells = <1>;
};

--
2.34.1

2023-01-09 11:44:13

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 2/4] arm64: dts: qcom: align OPP table node name with DT schema

Bindings expect OPP tables to start with "opp-table".

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>

---

Changes since v1:
1. Add tags.
2. Re-order nodes (Johan)
---
arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sa8540p.dtsi | 4 +-
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 388 ++++++++++-----------
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
4 files changed, 198 insertions(+), 198 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi
index 5728583af41e..929bdcd45d02 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi
@@ -19,7 +19,7 @@ / {
* features get enabled upstream.
*/

-gpu_opp_table_3_0: gpu-opp-table-30 {
+gpu_opp_table_3_0: opp-table-gpu30 {
compatible = "operating-points-v2";

opp-624000000 {
diff --git a/arch/arm64/boot/dts/qcom/sa8540p.dtsi b/arch/arm64/boot/dts/qcom/sa8540p.dtsi
index a88452c20d05..4a990fda8fc3 100644
--- a/arch/arm64/boot/dts/qcom/sa8540p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8540p.dtsi
@@ -10,7 +10,7 @@
/delete-node/ &cpu4_opp_table;

/ {
- cpu0_opp_table: cpu0-opp-table {
+ cpu0_opp_table: opp-table-cpu0 {
compatible = "operating-points-v2";
opp-shared;

@@ -92,7 +92,7 @@ opp-2246400000 {
};
};

- cpu4_opp_table: cpu4-opp-table {
+ cpu4_opp_table: opp-table-cpu4 {
compatible = "operating-points-v2";
opp-shared;

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 109c9d2b684d..79838ef8f8a6 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -33,186 +33,6 @@ sleep_clk: sleep-clk {
};
};

- cpu0_opp_table: cpu0-opp-table {
- compatible = "operating-points-v2";
- opp-shared;
-
- opp-300000000 {
- opp-hz = /bits/ 64 <300000000>;
- opp-peak-kBps = <(300000 * 32)>;
- };
- opp-403200000 {
- opp-hz = /bits/ 64 <403200000>;
- opp-peak-kBps = <(384000 * 32)>;
- };
- opp-499200000 {
- opp-hz = /bits/ 64 <499200000>;
- opp-peak-kBps = <(480000 * 32)>;
- };
- opp-595200000 {
- opp-hz = /bits/ 64 <595200000>;
- opp-peak-kBps = <(576000 * 32)>;
- };
- opp-691200000 {
- opp-hz = /bits/ 64 <691200000>;
- opp-peak-kBps = <(672000 * 32)>;
- };
- opp-806400000 {
- opp-hz = /bits/ 64 <806400000>;
- opp-peak-kBps = <(768000 * 32)>;
- };
- opp-902400000 {
- opp-hz = /bits/ 64 <902400000>;
- opp-peak-kBps = <(864000 * 32)>;
- };
- opp-1017600000 {
- opp-hz = /bits/ 64 <1017600000>;
- opp-peak-kBps = <(960000 * 32)>;
- };
- opp-1113600000 {
- opp-hz = /bits/ 64 <1113600000>;
- opp-peak-kBps = <(1075200 * 32)>;
- };
- opp-1209600000 {
- opp-hz = /bits/ 64 <1209600000>;
- opp-peak-kBps = <(1171200 * 32)>;
- };
- opp-1324800000 {
- opp-hz = /bits/ 64 <1324800000>;
- opp-peak-kBps = <(1267200 * 32)>;
- };
- opp-1440000000 {
- opp-hz = /bits/ 64 <1440000000>;
- opp-peak-kBps = <(1363200 * 32)>;
- };
- opp-1555200000 {
- opp-hz = /bits/ 64 <1555200000>;
- opp-peak-kBps = <(1536000 * 32)>;
- };
- opp-1670400000 {
- opp-hz = /bits/ 64 <1670400000>;
- opp-peak-kBps = <(1612800 * 32)>;
- };
- opp-1785600000 {
- opp-hz = /bits/ 64 <1785600000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-1881600000 {
- opp-hz = /bits/ 64 <1881600000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-1996800000 {
- opp-hz = /bits/ 64 <1996800000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2112000000 {
- opp-hz = /bits/ 64 <2112000000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2227200000 {
- opp-hz = /bits/ 64 <2227200000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2342400000 {
- opp-hz = /bits/ 64 <2342400000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2438400000 {
- opp-hz = /bits/ 64 <2438400000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- };
-
- cpu4_opp_table: cpu4-opp-table {
- compatible = "operating-points-v2";
- opp-shared;
-
- opp-825600000 {
- opp-hz = /bits/ 64 <825600000>;
- opp-peak-kBps = <(768000 * 32)>;
- };
- opp-940800000 {
- opp-hz = /bits/ 64 <940800000>;
- opp-peak-kBps = <(864000 * 32)>;
- };
- opp-1056000000 {
- opp-hz = /bits/ 64 <1056000000>;
- opp-peak-kBps = <(960000 * 32)>;
- };
- opp-1171200000 {
- opp-hz = /bits/ 64 <1171200000>;
- opp-peak-kBps = <(1171200 * 32)>;
- };
- opp-1286400000 {
- opp-hz = /bits/ 64 <1286400000>;
- opp-peak-kBps = <(1267200 * 32)>;
- };
- opp-1401600000 {
- opp-hz = /bits/ 64 <1401600000>;
- opp-peak-kBps = <(1363200 * 32)>;
- };
- opp-1516800000 {
- opp-hz = /bits/ 64 <1516800000>;
- opp-peak-kBps = <(1459200 * 32)>;
- };
- opp-1632000000 {
- opp-hz = /bits/ 64 <1632000000>;
- opp-peak-kBps = <(1612800 * 32)>;
- };
- opp-1747200000 {
- opp-hz = /bits/ 64 <1747200000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-1862400000 {
- opp-hz = /bits/ 64 <1862400000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-1977600000 {
- opp-hz = /bits/ 64 <1977600000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2073600000 {
- opp-hz = /bits/ 64 <2073600000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2169600000 {
- opp-hz = /bits/ 64 <2169600000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2284800000 {
- opp-hz = /bits/ 64 <2284800000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2400000000 {
- opp-hz = /bits/ 64 <2400000000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2496000000 {
- opp-hz = /bits/ 64 <2496000000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2592000000 {
- opp-hz = /bits/ 64 <2592000000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2688000000 {
- opp-hz = /bits/ 64 <2688000000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2803200000 {
- opp-hz = /bits/ 64 <2803200000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2899200000 {
- opp-hz = /bits/ 64 <2899200000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- opp-2995200000 {
- opp-hz = /bits/ 64 <2995200000>;
- opp-peak-kBps = <(1689600 * 32)>;
- };
- };
-
cpus {
#address-cells = <2>;
#size-cells = <0>;
@@ -528,6 +348,200 @@ memory@80000000 {
reg = <0x0 0x80000000 0x0 0x0>;
};

+ cpu0_opp_table: opp-table-cpu0 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp-300000000 {
+ opp-hz = /bits/ 64 <300000000>;
+ opp-peak-kBps = <(300000 * 32)>;
+ };
+ opp-403200000 {
+ opp-hz = /bits/ 64 <403200000>;
+ opp-peak-kBps = <(384000 * 32)>;
+ };
+ opp-499200000 {
+ opp-hz = /bits/ 64 <499200000>;
+ opp-peak-kBps = <(480000 * 32)>;
+ };
+ opp-595200000 {
+ opp-hz = /bits/ 64 <595200000>;
+ opp-peak-kBps = <(576000 * 32)>;
+ };
+ opp-691200000 {
+ opp-hz = /bits/ 64 <691200000>;
+ opp-peak-kBps = <(672000 * 32)>;
+ };
+ opp-806400000 {
+ opp-hz = /bits/ 64 <806400000>;
+ opp-peak-kBps = <(768000 * 32)>;
+ };
+ opp-902400000 {
+ opp-hz = /bits/ 64 <902400000>;
+ opp-peak-kBps = <(864000 * 32)>;
+ };
+ opp-1017600000 {
+ opp-hz = /bits/ 64 <1017600000>;
+ opp-peak-kBps = <(960000 * 32)>;
+ };
+ opp-1113600000 {
+ opp-hz = /bits/ 64 <1113600000>;
+ opp-peak-kBps = <(1075200 * 32)>;
+ };
+ opp-1209600000 {
+ opp-hz = /bits/ 64 <1209600000>;
+ opp-peak-kBps = <(1171200 * 32)>;
+ };
+ opp-1324800000 {
+ opp-hz = /bits/ 64 <1324800000>;
+ opp-peak-kBps = <(1267200 * 32)>;
+ };
+ opp-1440000000 {
+ opp-hz = /bits/ 64 <1440000000>;
+ opp-peak-kBps = <(1363200 * 32)>;
+ };
+ opp-1555200000 {
+ opp-hz = /bits/ 64 <1555200000>;
+ opp-peak-kBps = <(1536000 * 32)>;
+ };
+ opp-1670400000 {
+ opp-hz = /bits/ 64 <1670400000>;
+ opp-peak-kBps = <(1612800 * 32)>;
+ };
+ opp-1785600000 {
+ opp-hz = /bits/ 64 <1785600000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-1881600000 {
+ opp-hz = /bits/ 64 <1881600000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-1996800000 {
+ opp-hz = /bits/ 64 <1996800000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2112000000 {
+ opp-hz = /bits/ 64 <2112000000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2227200000 {
+ opp-hz = /bits/ 64 <2227200000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2342400000 {
+ opp-hz = /bits/ 64 <2342400000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2438400000 {
+ opp-hz = /bits/ 64 <2438400000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ };
+
+ cpu4_opp_table: opp-table-cpu4 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp-825600000 {
+ opp-hz = /bits/ 64 <825600000>;
+ opp-peak-kBps = <(768000 * 32)>;
+ };
+ opp-940800000 {
+ opp-hz = /bits/ 64 <940800000>;
+ opp-peak-kBps = <(864000 * 32)>;
+ };
+ opp-1056000000 {
+ opp-hz = /bits/ 64 <1056000000>;
+ opp-peak-kBps = <(960000 * 32)>;
+ };
+ opp-1171200000 {
+ opp-hz = /bits/ 64 <1171200000>;
+ opp-peak-kBps = <(1171200 * 32)>;
+ };
+ opp-1286400000 {
+ opp-hz = /bits/ 64 <1286400000>;
+ opp-peak-kBps = <(1267200 * 32)>;
+ };
+ opp-1401600000 {
+ opp-hz = /bits/ 64 <1401600000>;
+ opp-peak-kBps = <(1363200 * 32)>;
+ };
+ opp-1516800000 {
+ opp-hz = /bits/ 64 <1516800000>;
+ opp-peak-kBps = <(1459200 * 32)>;
+ };
+ opp-1632000000 {
+ opp-hz = /bits/ 64 <1632000000>;
+ opp-peak-kBps = <(1612800 * 32)>;
+ };
+ opp-1747200000 {
+ opp-hz = /bits/ 64 <1747200000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-1862400000 {
+ opp-hz = /bits/ 64 <1862400000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-1977600000 {
+ opp-hz = /bits/ 64 <1977600000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2073600000 {
+ opp-hz = /bits/ 64 <2073600000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2169600000 {
+ opp-hz = /bits/ 64 <2169600000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2284800000 {
+ opp-hz = /bits/ 64 <2284800000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2400000000 {
+ opp-hz = /bits/ 64 <2400000000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2496000000 {
+ opp-hz = /bits/ 64 <2496000000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2592000000 {
+ opp-hz = /bits/ 64 <2592000000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2688000000 {
+ opp-hz = /bits/ 64 <2688000000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2803200000 {
+ opp-hz = /bits/ 64 <2803200000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2899200000 {
+ opp-hz = /bits/ 64 <2899200000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ opp-2995200000 {
+ opp-hz = /bits/ 64 <2995200000>;
+ opp-peak-kBps = <(1689600 * 32)>;
+ };
+ };
+
+ qup_opp_table_100mhz: opp-table-qup100mhz {
+ compatible = "operating-points-v2";
+
+ opp-75000000 {
+ opp-hz = /bits/ 64 <75000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-100000000 {
+ opp-hz = /bits/ 64 <100000000>;
+ required-opps = <&rpmhpd_opp_svs>;
+ };
+ };
+
pmu {
compatible = "arm,armv8-pmuv3";
interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
@@ -591,20 +605,6 @@ CLUSTER_PD: cpu-cluster0 {
};
};

- qup_opp_table_100mhz: qup-100mhz-opp-table {
- compatible = "operating-points-v2";
-
- opp-75000000 {
- opp-hz = /bits/ 64 <75000000>;
- required-opps = <&rpmhpd_opp_low_svs>;
- };
-
- opp-100000000 {
- opp-hz = /bits/ 64 <100000000>;
- required-opps = <&rpmhpd_opp_svs>;
- };
- };
-
reserved-memory {
#address-cells = <2>;
#size-cells = <2>;
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 65032b94b46d..ba48adc01170 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -4619,7 +4619,7 @@ port@1 {
};
};

- dp_opp_table: dp-opp-table {
+ dp_opp_table: opp-table {
compatible = "operating-points-v2";

opp-162000000 {
--
2.34.1

2023-01-19 03:46:03

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH v2 1/4] ARM: dts: qcom: align OPP table node name with DT schema

On Mon, 9 Jan 2023 12:22:18 +0100, Krzysztof Kozlowski wrote:
> Bindings expect OPP tables to start with "opp-table".
>
>

Applied, thanks!

[2/4] arm64: dts: qcom: align OPP table node name with DT schema
commit: 8a220a62ebe2ade6ee371aa4fcbdb344b32264ad
[3/4] arm64: dts: qcom: sm8250: drop unused clock-frequency from wsa-macro
commit: a496f7decf4f86bcb34c78041d8db9690cc93aae
[4/4] arm64: dts: qcom: sm8250: drop unused properties from tx-macro
commit: e5988fd6004bb3ea5a9669933c1a9beaf7637990

Best regards,
--
Bjorn Andersson <[email protected]>