2023-01-10 08:14:43

by Guo Ren

Subject: [PATCH] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE

From: Guo Ren <[email protected]>

KERN_VIRT_SIZE is 1/4 of the entries of the page global directory,
not half.

Fixes: f7ae02333d13 ("riscv: Move KASAN mapping next to the kernel mapping")
Signed-off-by: Guo Ren <[email protected]>
Signed-off-by: Guo Ren <[email protected]>
Cc: Alexandre Ghiti <[email protected]>
---
arch/riscv/include/asm/pgtable.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
index 4eba9a98d0e3..2a88362dffa5 100644
--- a/arch/riscv/include/asm/pgtable.h
+++ b/arch/riscv/include/asm/pgtable.h
@@ -31,7 +31,7 @@
#define PTRS_PER_PTE (PAGE_SIZE / sizeof(pte_t))

/*
- * Half of the kernel address space (half of the entries of the page global
+ * Half of the kernel address space (1/4 of the entries of the page global
* directory) is for the direct mapping.
*/
#define KERN_VIRT_SIZE ((PTRS_PER_PGD / 2 * PGDIR_SIZE) / 2)
--
2.36.1

2023-01-10 11:04:30

by Alexandre Ghiti

Subject: Re: [PATCH] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE

Hi Guo,

On 1/10/23 09:04, [email protected] wrote:
> From: Guo Ren <[email protected]>
>
> KERN_VIRT_SIZE is 1/4 of the entries of the page global directory,
> not half.
>
> Fixes: f7ae02333d13 ("riscv: Move KASAN mapping next to the kernel mapping")
> Signed-off-by: Guo Ren <[email protected]>
> Signed-off-by: Guo Ren <[email protected]>
> Cc: Alexandre Ghiti <[email protected]>
> ---
> arch/riscv/include/asm/pgtable.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> index 4eba9a98d0e3..2a88362dffa5 100644
> --- a/arch/riscv/include/asm/pgtable.h
> +++ b/arch/riscv/include/asm/pgtable.h
> @@ -31,7 +31,7 @@
> #define PTRS_PER_PTE (PAGE_SIZE / sizeof(pte_t))
>
> /*
> - * Half of the kernel address space (half of the entries of the page global
> + * Half of the kernel address space (1/4 of the entries of the page global


Reviewed-by: Alexandre Ghiti <[email protected]>

Thanks,

Alex


> * directory) is for the direct mapping.
> */
> #define KERN_VIRT_SIZE ((PTRS_PER_PGD / 2 * PGDIR_SIZE) / 2)

2023-01-25 03:49:48

by Palmer Dabbelt

Subject: Re: [PATCH] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE

On Tue, 10 Jan 2023 03:04:19 -0500, [email protected] wrote:
> From: Guo Ren <[email protected]>
>
> KERN_VIRT_SIZE is 1/4 of the entries of the page global directory,
> not half.
>
>

Applied, thanks!

[1/1] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE
https://git.kernel.org/palmer/c/6be1ff430dab

Best regards,
--
Palmer Dabbelt <[email protected]>

2023-01-25 03:50:33

by patchwork-bot+linux-riscv

Subject: Re: [PATCH] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <[email protected]>:

On Tue, 10 Jan 2023 03:04:19 -0500 you wrote:
> From: Guo Ren <[email protected]>
>
> KERN_VIRT_SIZE is 1/4 of the entries of the page global directory,
> not half.
>
> Fixes: f7ae02333d13 ("riscv: Move KASAN mapping next to the kernel mapping")
> Signed-off-by: Guo Ren <[email protected]>
> Signed-off-by: Guo Ren <[email protected]>
> Cc: Alexandre Ghiti <[email protected]>
>
> [...]

Here is the summary with links:
- riscv: pgtable: Fixup comment for KERN_VIRT_SIZE
https://git.kernel.org/riscv/c/6be1ff430dab

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html