2023-01-30 12:13:56

by Ulf Hansson

Subject: [PATCH] block: Default to use cgroup support for BFQ

Assuming that both Kconfig options, BLK_CGROUP and IOSCHED_BFQ are set, we
most likely want cgroup support for BFQ too (BFQ_GROUP_IOSCHED), so let's
make it default y.

Signed-off-by: Ulf Hansson <[email protected]>
---
block/Kconfig.iosched | 1 +
1 file changed, 1 insertion(+)

diff --git a/block/Kconfig.iosched b/block/Kconfig.iosched
index 615516146086..27f11320b8d1 100644
--- a/block/Kconfig.iosched
+++ b/block/Kconfig.iosched
@@ -30,6 +30,7 @@ config IOSCHED_BFQ
config BFQ_GROUP_IOSCHED
bool "BFQ hierarchical scheduling support"
depends on IOSCHED_BFQ && BLK_CGROUP
+ default y
select BLK_CGROUP_RWSTAT
help

--
2.34.1

2023-01-30 14:51:34

by Linus Walleij

Subject: Re: [PATCH] block: Default to use cgroup support for BFQ

On Mon, Jan 30, 2023 at 1:12 PM Ulf Hansson <[email protected]> wrote:

> Assuming that both Kconfig options, BLK_CGROUP and IOSCHED_BFQ are set, we
> most likely want cgroup support for BFQ too (BFQ_GROUP_IOSCHED), so let's
> make it default y.
>
> Signed-off-by: Ulf Hansson <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2023-01-30 16:43:14

by Jens Axboe

Subject: Re: [PATCH] block: Default to use cgroup support for BFQ

On Mon, 30 Jan 2023 13:12:40 +0100, Ulf Hansson wrote:
> Assuming that both Kconfig options, BLK_CGROUP and IOSCHED_BFQ are set, we
> most likely want cgroup support for BFQ too (BFQ_GROUP_IOSCHED), so let's
> make it default y.
>
>

Applied, thanks!

[1/1] block: Default to use cgroup support for BFQ
commit: 4a6a7bc21d4726c5772e47525e6039852555b391

Best regards,
--
Jens Axboe