2023-01-31 18:29:00

by Mark Brown

[permalink] [raw]
Subject: [PATCH] kselftest/arm64: Don't require FA64 for streaming SVE tests

During early development a dependedncy was added on having FA64
available so we could use the full FPSIMD register set in the signal
handler. Subsequently the ABI was finialised so the handler is run with
streaming mode disabled meaning this is redundant but the dependency was
never removed, do so now.

Signed-off-by: Mark Brown <[email protected]>
---
tools/testing/selftests/arm64/signal/testcases/ssve_regs.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/tools/testing/selftests/arm64/signal/testcases/ssve_regs.c b/tools/testing/selftests/arm64/signal/testcases/ssve_regs.c
index d0a178945b1a..f0985da7936e 100644
--- a/tools/testing/selftests/arm64/signal/testcases/ssve_regs.c
+++ b/tools/testing/selftests/arm64/signal/testcases/ssve_regs.c
@@ -116,12 +116,7 @@ static int sme_regs(struct tdescr *td, siginfo_t *si, ucontext_t *uc)
struct tdescr tde = {
.name = "Streaming SVE registers",
.descr = "Check that we get the right Streaming SVE registers reported",
- /*
- * We shouldn't require FA64 but things like memset() used in the
- * helpers might use unsupported instructions so for now disable
- * the test unless we've got the full instruction set.
- */
- .feats_required = FEAT_SME | FEAT_SME_FA64,
+ .feats_required = FEAT_SME,
.timeout = 3,
.init = sme_get_vls,
.run = sme_regs,

---
base-commit: b7bfaa761d760e72a969d116517eaa12e404c262
change-id: 20230131-arm64-kselfetest-ssve-fa64-cec2031da43f

Best regards,
--
Mark Brown <[email protected]>



2023-02-01 19:31:13

by Catalin Marinas

[permalink] [raw]
Subject: Re: [PATCH] kselftest/arm64: Don't require FA64 for streaming SVE tests

On Tue, 31 Jan 2023 18:28:05 +0000, Mark Brown wrote:
> During early development a dependedncy was added on having FA64
> available so we could use the full FPSIMD register set in the signal
> handler. Subsequently the ABI was finialised so the handler is run with
> streaming mode disabled meaning this is redundant but the dependency was
> never removed, do so now.
>
>
> [...]

Applied to arm64 (for-next/kselftest), thanks!

[1/1] kselftest/arm64: Don't require FA64 for streaming SVE tests
https://git.kernel.org/arm64/c/4365eec8190c

--
Catalin