2023-02-03 09:31:22

by Archie Pusaka

Subject: [PATCH] Bluetooth: Free potentially unfreed SCO connection

From: Archie Pusaka <[email protected]>

It is possible to initiate a SCO connection while deleting the
corresponding ACL connection, e.g. in below scenario:

(1) < hci setup sync connect command
(2) > hci disconn complete event (for the acl connection)
(3) > hci command complete event (for(1), failure)

When it happens, hci_cs_setup_sync_conn won't be able to obtain the
reference to the SCO connection, so it will be stuck and potentially
hinder subsequent connections to the same device.

This patch prevents that by also deleting the SCO connection if it is
still not established when the corresponding ACL connection is deleted.

Signed-off-by: Archie Pusaka <[email protected]>
Reviewed-by: Ying Hsu <[email protected]>

---

net/bluetooth/hci_conn.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 61a34801e61e..838f51c272a6 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -1061,8 +1061,15 @@ int hci_conn_del(struct hci_conn *conn)

if (conn->type == ACL_LINK) {
struct hci_conn *sco = conn->link;
- if (sco)
+ if (sco) {
sco->link = NULL;
+ /* Due to race, SCO connection might be not established
+ * yet at this point. Delete it now, otherwise it is
+ * possible for it to be stuck and can't be deleted.
+ */
+ if (sco->handle == HCI_CONN_HANDLE_UNSET)
+ hci_conn_del(sco);
+ }

/* Unacked frames */
hdev->acl_cnt += conn->sent;
--
2.39.1.519.gcb327c4b5f-goog

2023-02-03 20:30:27

by patchwork-bot+bluetooth

Subject: Re: [PATCH] Bluetooth: Free potentially unfreed SCO connection

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Fri, 3 Feb 2023 17:30:55 +0800 you wrote:
> From: Archie Pusaka <[email protected]>
>
> It is possible to initiate a SCO connection while deleting the
> corresponding ACL connection, e.g. in below scenario:
>
> (1) < hci setup sync connect command
> (2) > hci disconn complete event (for the acl connection)
> (3) > hci command complete event (for(1), failure)
>
> [...]

Here is the summary with links:
- Bluetooth: Free potentially unfreed SCO connection
https://git.kernel.org/bluetooth/bluetooth-next/c/c2c762af5650

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html