2023-01-27 12:02:11

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] arm64: dts: qcom: sm8550: add specific SMMU compatible

Generic SMMU compatibles are not allowed alone and we expect specific
one.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Compatible is documented here:
https://lore.kernel.org/all/[email protected]/
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 0307b853ec4f..e385432e7a22 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -3053,7 +3053,7 @@ data-pins {
};

apps_smmu: iommu@15000000 {
- compatible = "qcom,smmu-500", "arm,mmu-500";
+ compatible = "qcom,sm8550-smmu-500", "qcom,smmu-500", "arm,mmu-500";
reg = <0 0x15000000 0 0x100000>;
#iommu-cells = <2>;
#global-interrupts = <1>;
--
2.34.1



2023-01-27 12:34:14

by Abel Vesa

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sm8550: add specific SMMU compatible

On 23-01-27 12:55:13, Krzysztof Kozlowski wrote:
> Generic SMMU compatibles are not allowed alone and we expect specific
> one.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>

Reviewed-by: Abel Vesa <[email protected]>

> ---
>
> Compatible is documented here:
> https://lore.kernel.org/all/[email protected]/
> ---
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 0307b853ec4f..e385432e7a22 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -3053,7 +3053,7 @@ data-pins {
> };
>
> apps_smmu: iommu@15000000 {
> - compatible = "qcom,smmu-500", "arm,mmu-500";
> + compatible = "qcom,sm8550-smmu-500", "qcom,smmu-500", "arm,mmu-500";
> reg = <0 0x15000000 0 0x100000>;
> #iommu-cells = <2>;
> #global-interrupts = <1>;
> --
> 2.34.1
>

2023-02-09 04:32:28

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sm8550: add specific SMMU compatible

On Fri, 27 Jan 2023 12:55:13 +0100, Krzysztof Kozlowski wrote:
> Generic SMMU compatibles are not allowed alone and we expect specific
> one.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sm8550: add specific SMMU compatible
commit: 88ec7fb6751e7e1d05d756c9764667aab7428044

Best regards,
--
Bjorn Andersson <[email protected]>