2023-03-24 07:40:53

by Sergio Paracuellos

Subject: [PATCH] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace

When there is no card plugged on PCIe port a trace that says the port will
be disabled appears. This is expected behaviour but currently is using
'dev_err' for doing that. Since this is not an error at all, change the
trace to use 'dev_info' instead.

Signed-off-by: Sergio Paracuellos <[email protected]>
---
drivers/pci/controller/pcie-mt7621.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c
index 63a5f4463a9f..a445ec314375 100644
--- a/drivers/pci/controller/pcie-mt7621.c
+++ b/drivers/pci/controller/pcie-mt7621.c
@@ -378,8 +378,8 @@ static int mt7621_pcie_init_ports(struct mt7621_pcie *pcie)
u32 slot = port->slot;

if (!mt7621_pcie_port_is_linkup(port)) {
- dev_err(dev, "pcie%d no card, disable it (RST & CLK)\n",
- slot);
+ dev_info(dev, "pcie%d no card, disable it (RST & CLK)\n",
+ slot);
mt7621_control_assert(port);
port->enabled = false;
num_disabled++;
--
2.25.1

2023-03-24 15:44:49

by Lorenzo Pieralisi

Subject: Re: [PATCH] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace

On Fri, 24 Mar 2023 08:37:33 +0100, Sergio Paracuellos wrote:
> When there is no card plugged on PCIe port a trace that says the port will
> be disabled appears. This is expected behaviour but currently is using
> 'dev_err' for doing that. Since this is not an error at all, change the
> trace to use 'dev_info' instead.
>
>

Applied to controller/mt7621, thanks!

[1/1] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace
https://git.kernel.org/pci/pci/c/50233e105a03

Thanks,
Lorenzo

2023-03-28 08:22:17

by Sergio Paracuellos

Subject: Re: [PATCH] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace

On Fri, Mar 24, 2023 at 4:41 PM Lorenzo Pieralisi <[email protected]> wrote:
>
> On Fri, 24 Mar 2023 08:37:33 +0100, Sergio Paracuellos wrote:
> > When there is no card plugged on PCIe port a trace that says the port will
> > be disabled appears. This is expected behaviour but currently is using
> > 'dev_err' for doing that. Since this is not an error at all, change the
> > trace to use 'dev_info' instead.
> >
> >
>
> Applied to controller/mt7621, thanks!
>
> [1/1] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace
> https://git.kernel.org/pci/pci/c/50233e105a03
>
> Thanks,
> Lorenzo

Thanks, Lorenzo!

Best regards,
Sergio Paracuellos