2023-03-31 08:09:19

by Stefano Garzarella

[permalink] [raw]
Subject: [PATCH] vringh: fix typos in the vringh_init_* documentation

Replace `userpace` with `userspace`.

Cc: Simon Horman <[email protected]>
Signed-off-by: Stefano Garzarella <[email protected]>
---
drivers/vhost/vringh.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
index a1e27da54481..694462ba3242 100644
--- a/drivers/vhost/vringh.c
+++ b/drivers/vhost/vringh.c
@@ -636,9 +636,9 @@ static inline int xfer_to_user(const struct vringh *vrh,
* @features: the feature bits for this ring.
* @num: the number of elements.
* @weak_barriers: true if we only need memory barriers, not I/O.
- * @desc: the userpace descriptor pointer.
- * @avail: the userpace avail pointer.
- * @used: the userpace used pointer.
+ * @desc: the userspace descriptor pointer.
+ * @avail: the userspace avail pointer.
+ * @used: the userspace used pointer.
*
* Returns an error if num is invalid: you should check pointers
* yourself!
@@ -911,9 +911,9 @@ static inline int kern_xfer(const struct vringh *vrh, void *dst,
* @features: the feature bits for this ring.
* @num: the number of elements.
* @weak_barriers: true if we only need memory barriers, not I/O.
- * @desc: the userpace descriptor pointer.
- * @avail: the userpace avail pointer.
- * @used: the userpace used pointer.
+ * @desc: the userspace descriptor pointer.
+ * @avail: the userspace avail pointer.
+ * @used: the userspace used pointer.
*
* Returns an error if num is invalid.
*/
@@ -1306,9 +1306,9 @@ static inline int putused_iotlb(const struct vringh *vrh,
* @features: the feature bits for this ring.
* @num: the number of elements.
* @weak_barriers: true if we only need memory barriers, not I/O.
- * @desc: the userpace descriptor pointer.
- * @avail: the userpace avail pointer.
- * @used: the userpace used pointer.
+ * @desc: the userspace descriptor pointer.
+ * @avail: the userspace avail pointer.
+ * @used: the userspace used pointer.
*
* Returns an error if num is invalid.
*/
--
2.39.2


2023-03-31 08:12:58

by Xuan Zhuo

[permalink] [raw]
Subject: Re: [PATCH] vringh: fix typos in the vringh_init_* documentation

On Fri, 31 Mar 2023 10:02:08 +0200, Stefano Garzarella <[email protected]> wrote:
> Replace `userpace` with `userspace`.
>
> Cc: Simon Horman <[email protected]>
> Signed-off-by: Stefano Garzarella <[email protected]>

Reviewed-by: Xuan Zhuo <[email protected]>

Thanks

> ---
> drivers/vhost/vringh.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
> index a1e27da54481..694462ba3242 100644
> --- a/drivers/vhost/vringh.c
> +++ b/drivers/vhost/vringh.c
> @@ -636,9 +636,9 @@ static inline int xfer_to_user(const struct vringh *vrh,
> * @features: the feature bits for this ring.
> * @num: the number of elements.
> * @weak_barriers: true if we only need memory barriers, not I/O.
> - * @desc: the userpace descriptor pointer.
> - * @avail: the userpace avail pointer.
> - * @used: the userpace used pointer.
> + * @desc: the userspace descriptor pointer.
> + * @avail: the userspace avail pointer.
> + * @used: the userspace used pointer.
> *
> * Returns an error if num is invalid: you should check pointers
> * yourself!
> @@ -911,9 +911,9 @@ static inline int kern_xfer(const struct vringh *vrh, void *dst,
> * @features: the feature bits for this ring.
> * @num: the number of elements.
> * @weak_barriers: true if we only need memory barriers, not I/O.
> - * @desc: the userpace descriptor pointer.
> - * @avail: the userpace avail pointer.
> - * @used: the userpace used pointer.
> + * @desc: the userspace descriptor pointer.
> + * @avail: the userspace avail pointer.
> + * @used: the userspace used pointer.
> *
> * Returns an error if num is invalid.
> */
> @@ -1306,9 +1306,9 @@ static inline int putused_iotlb(const struct vringh *vrh,
> * @features: the feature bits for this ring.
> * @num: the number of elements.
> * @weak_barriers: true if we only need memory barriers, not I/O.
> - * @desc: the userpace descriptor pointer.
> - * @avail: the userpace avail pointer.
> - * @used: the userpace used pointer.
> + * @desc: the userspace descriptor pointer.
> + * @avail: the userspace avail pointer.
> + * @used: the userspace used pointer.
> *
> * Returns an error if num is invalid.
> */
> --
> 2.39.2
>
> _______________________________________________
> Virtualization mailing list
> [email protected]
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization

2023-03-31 09:27:45

by Jason Wang

[permalink] [raw]
Subject: Re: [PATCH] vringh: fix typos in the vringh_init_* documentation

On Fri, Mar 31, 2023 at 4:02 PM Stefano Garzarella <[email protected]> wrote:
>
> Replace `userpace` with `userspace`.
>
> Cc: Simon Horman <[email protected]>
> Signed-off-by: Stefano Garzarella <[email protected]>

Acked-by: Jason Wang <[email protected]>

Thanks

> ---
> drivers/vhost/vringh.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
> index a1e27da54481..694462ba3242 100644
> --- a/drivers/vhost/vringh.c
> +++ b/drivers/vhost/vringh.c
> @@ -636,9 +636,9 @@ static inline int xfer_to_user(const struct vringh *vrh,
> * @features: the feature bits for this ring.
> * @num: the number of elements.
> * @weak_barriers: true if we only need memory barriers, not I/O.
> - * @desc: the userpace descriptor pointer.
> - * @avail: the userpace avail pointer.
> - * @used: the userpace used pointer.
> + * @desc: the userspace descriptor pointer.
> + * @avail: the userspace avail pointer.
> + * @used: the userspace used pointer.
> *
> * Returns an error if num is invalid: you should check pointers
> * yourself!
> @@ -911,9 +911,9 @@ static inline int kern_xfer(const struct vringh *vrh, void *dst,
> * @features: the feature bits for this ring.
> * @num: the number of elements.
> * @weak_barriers: true if we only need memory barriers, not I/O.
> - * @desc: the userpace descriptor pointer.
> - * @avail: the userpace avail pointer.
> - * @used: the userpace used pointer.
> + * @desc: the userspace descriptor pointer.
> + * @avail: the userspace avail pointer.
> + * @used: the userspace used pointer.
> *
> * Returns an error if num is invalid.
> */
> @@ -1306,9 +1306,9 @@ static inline int putused_iotlb(const struct vringh *vrh,
> * @features: the feature bits for this ring.
> * @num: the number of elements.
> * @weak_barriers: true if we only need memory barriers, not I/O.
> - * @desc: the userpace descriptor pointer.
> - * @avail: the userpace avail pointer.
> - * @used: the userpace used pointer.
> + * @desc: the userspace descriptor pointer.
> + * @avail: the userspace avail pointer.
> + * @used: the userspace used pointer.
> *
> * Returns an error if num is invalid.
> */
> --
> 2.39.2
>

2023-03-31 10:57:32

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] vringh: fix typos in the vringh_init_* documentation

On Fri, Mar 31, 2023 at 10:02:08AM +0200, Stefano Garzarella wrote:
> Replace `userpace` with `userspace`.
>
> Cc: Simon Horman <[email protected]>
> Signed-off-by: Stefano Garzarella <[email protected]>

Thanks, LGTM.