2023-04-02 03:19:36

by Yohan Joung

Subject: [PATCH v2] f2fs: fix align check for npo2

From: Yohan Joung <[email protected]>

Fix alignment check to be correct in npo2 as well

Signed-off-by: Yohan Joung <[email protected]>
---
fs/f2fs/segment.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 055e70e77aa2..c1525168f265 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1842,6 +1842,7 @@ static int __f2fs_issue_discard_zone(struct f2fs_sb_info *sbi,
sector_t sector, nr_sects;
block_t lblkstart = blkstart;
int devi = 0;
+ u64 remainder = 0;

if (f2fs_is_multi_device(sbi)) {
devi = f2fs_target_device_index(sbi, blkstart);
@@ -1857,9 +1858,9 @@ static int __f2fs_issue_discard_zone(struct f2fs_sb_info *sbi,
if (f2fs_blkz_is_seq(sbi, devi, blkstart)) {
sector = SECTOR_FROM_BLOCK(blkstart);
nr_sects = SECTOR_FROM_BLOCK(blklen);
+ div64_u64_rem(sector, bdev_zone_sectors(bdev), &remainder);

- if (sector & (bdev_zone_sectors(bdev) - 1) ||
- nr_sects != bdev_zone_sectors(bdev)) {
+ if (remainder || nr_sects != bdev_zone_sectors(bdev)) {
f2fs_err(sbi, "(%d) %s: Unaligned zone reset attempted (block %x + %x)",
devi, sbi->s_ndevs ? FDEV(devi).path : "",
blkstart, blklen);
--
2.25.1

2023-04-02 14:29:00

by Chao Yu

Subject: Re: [PATCH v2] f2fs: fix align check for npo2

On 2023/4/2 11:12, Yohan Joung wrote:
> From: Yohan Joung <[email protected]>
>
> Fix alignment check to be correct in npo2 as well
>
> Signed-off-by: Yohan Joung <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2023-04-03 18:32:34

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix align check for npo2

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Sun, 2 Apr 2023 12:12:59 +0900 you wrote:
> From: Yohan Joung <[email protected]>
>
> Fix alignment check to be correct in npo2 as well
>
> Signed-off-by: Yohan Joung <[email protected]>
> ---
> fs/f2fs/segment.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)

Here is the summary with links:
- [f2fs-dev,v2] f2fs: fix align check for npo2
https://git.kernel.org/jaegeuk/f2fs/c/2aeb9c3b9a3c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html