2023-03-27 11:49:59

by Kautuk Consul

Subject: [PATCH v5] KVM: PPC: Book3S HV: kvmppc_hv_entry: remove .global scope

kvmppc_hv_entry isn't called from anywhere other than
book3s_hv_rmhandlers.S itself. Removing .global scope for
this function and annotating it with SYM_CODE_START_LOCAL
and SYM_CODE_END.

Signed-off-by: Kautuk Consul <[email protected]>
---
arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
index acf80915f406..0a9781192b86 100644
--- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
+++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
@@ -502,8 +502,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_ARCH_207S)
* *
*****************************************************************************/

-.global kvmppc_hv_entry
-kvmppc_hv_entry:
+SYM_CODE_START_LOCAL(kvmppc_hv_entry)

/* Required state:
*
@@ -940,6 +939,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_HAS_PPR)
ld r4, VCPU_GPR(R4)(r4)
HRFI_TO_GUEST
b .
+SYM_CODE_END(kvmppc_hv_entry)

secondary_too_late:
li r12, 0
--
2.39.2

2023-04-06 00:41:24

by Michael Ellerman

Subject: Re: [PATCH v5] KVM: PPC: Book3S HV: kvmppc_hv_entry: remove .global scope

On Mon, 27 Mar 2023 07:33:20 -0400, Kautuk Consul wrote:
> kvmppc_hv_entry isn't called from anywhere other than
> book3s_hv_rmhandlers.S itself. Removing .global scope for
> this function and annotating it with SYM_CODE_START_LOCAL
> and SYM_CODE_END.
>
>

Applied to powerpc/topic/ppc-kvm.

[1/1] KVM: PPC: Book3S HV: kvmppc_hv_entry: remove .global scope
https://git.kernel.org/powerpc/c/5f4f53d28cde2cc7be96f657229c8603da578500

cheers