2023-03-27 22:38:24

by Rob Herring (Arm)

Subject: [PATCH] powerpc: usbgecko: Use of_iomap()

Replace of_get_property()+of_translate_address()+ioremap() with a call
to of_iomap() which does all those steps.

Signed-off-by: Rob Herring <[email protected]>
---
.../platforms/embedded6xx/usbgecko_udbg.c | 20 +------------------
1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
index e02bdabf358c..221577f32b01 100644
--- a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
+++ b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
@@ -192,24 +192,6 @@ static int ug_udbg_getc_poll(void)
return ug_getc();
}

-/*
- * Retrieves and prepares the virtual address needed to access the hardware.
- */
-static void __iomem *__init ug_udbg_setup_exi_io_base(struct device_node *np)
-{
- void __iomem *exi_io_base = NULL;
- phys_addr_t paddr;
- const unsigned int *reg;
-
- reg = of_get_property(np, "reg", NULL);
- if (reg) {
- paddr = of_translate_address(np, reg);
- if (paddr)
- exi_io_base = ioremap(paddr, reg[1]);
- }
- return exi_io_base;
-}
-
/*
* Checks if a USB Gecko adapter is inserted in any memory card slot.
*/
@@ -246,7 +228,7 @@ void __init ug_udbg_init(void)
goto out;
}

- exi_io_base = ug_udbg_setup_exi_io_base(np);
+ exi_io_base = of_iomap(np, 0);
if (!exi_io_base) {
udbg_printf("%s: failed to setup EXI io base\n", __func__);
goto done;
--
2.39.2

2023-04-06 01:12:15

by Michael Ellerman

Subject: Re: [PATCH] powerpc: usbgecko: Use of_iomap()

On Mon, 27 Mar 2023 17:31:09 -0500, Rob Herring wrote:
> Replace of_get_property()+of_translate_address()+ioremap() with a call
> to of_iomap() which does all those steps.
>
>

Applied to powerpc/next.

[1/1] powerpc: usbgecko: Use of_iomap()
https://git.kernel.org/powerpc/c/83a8fe569ef84d6eefcb99420a731cb87508f004

cheers