2023-04-07 19:28:46

by Krzysztof Kozlowski

Subject: [PATCH] arm64: dts: qcom: sdm630: move DSI opp-table out of DSI node

The DSI OPP table on SDM630 is used by one DSI0, but on SDM660 is shared
by two nodes (DSI0 and DSI1), thus it should be rather in top-level, not
in DSI0.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

A cleanup patch to commit a2e5260d0755 ("arm64: dts: qcom: sdm630: move
DSI opp-table into DSI node").

Follow-up to:
https://lore.kernel.org/all/20230407163442.ckbd4vxa5b2xu3eu@ripper/
---
arch/arm64/boot/dts/qcom/sdm630.dtsi | 38 ++++++++++++++--------------
1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
index 8bdb36a63474..b91e423a3cfc 100644
--- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
@@ -328,6 +328,25 @@ memory@80000000 {
reg = <0x0 0x80000000 0x0 0x0>;
};

+ dsi_opp_table: opp-table-dsi {
+ compatible = "operating-points-v2";
+
+ opp-131250000 {
+ opp-hz = /bits/ 64 <131250000>;
+ required-opps = <&rpmpd_opp_svs>;
+ };
+
+ opp-210000000 {
+ opp-hz = /bits/ 64 <210000000>;
+ required-opps = <&rpmpd_opp_svs_plus>;
+ };
+
+ opp-262500000 {
+ opp-hz = /bits/ 64 <262500000>;
+ required-opps = <&rpmpd_opp_nom>;
+ };
+ };
+
pmu {
compatible = "arm,armv8-pmuv3";
interrupts = <GIC_PPI 6 IRQ_TYPE_LEVEL_HIGH>;
@@ -1591,25 +1610,6 @@ dsi0: dsi@c994000 {

status = "disabled";

- dsi_opp_table: opp-table {
- compatible = "operating-points-v2";
-
- opp-131250000 {
- opp-hz = /bits/ 64 <131250000>;
- required-opps = <&rpmpd_opp_svs>;
- };
-
- opp-210000000 {
- opp-hz = /bits/ 64 <210000000>;
- required-opps = <&rpmpd_opp_svs_plus>;
- };
-
- opp-262500000 {
- opp-hz = /bits/ 64 <262500000>;
- required-opps = <&rpmpd_opp_nom>;
- };
- };
-
ports {
#address-cells = <1>;
#size-cells = <0>;
--
2.34.1

2023-04-07 19:34:48

by Konrad Dybcio

Subject: Re: [PATCH] arm64: dts: qcom: sdm630: move DSI opp-table out of DSI node

On 7.04.2023 21:26, Krzysztof Kozlowski wrote:
> The DSI OPP table on SDM630 is used by one DSI0, but on SDM660 is shared
> by two nodes (DSI0 and DSI1), thus it should be rather in top-level, not
> in DSI0.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> A cleanup patch to commit a2e5260d0755 ("arm64: dts: qcom: sdm630: move
> DSI opp-table into DSI node").
>
> Follow-up to:
> https://lore.kernel.org/all/20230407163442.ckbd4vxa5b2xu3eu@ripper/
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sdm630.dtsi | 38 ++++++++++++++--------------
> 1 file changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index 8bdb36a63474..b91e423a3cfc 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -328,6 +328,25 @@ memory@80000000 {
> reg = <0x0 0x80000000 0x0 0x0>;
> };
>
> + dsi_opp_table: opp-table-dsi {
> + compatible = "operating-points-v2";
> +
> + opp-131250000 {
> + opp-hz = /bits/ 64 <131250000>;
> + required-opps = <&rpmpd_opp_svs>;
> + };
> +
> + opp-210000000 {
> + opp-hz = /bits/ 64 <210000000>;
> + required-opps = <&rpmpd_opp_svs_plus>;
> + };
> +
> + opp-262500000 {
> + opp-hz = /bits/ 64 <262500000>;
> + required-opps = <&rpmpd_opp_nom>;
> + };
> + };
> +
> pmu {
> compatible = "arm,armv8-pmuv3";
> interrupts = <GIC_PPI 6 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1591,25 +1610,6 @@ dsi0: dsi@c994000 {
>
> status = "disabled";
>
> - dsi_opp_table: opp-table {
> - compatible = "operating-points-v2";
> -
> - opp-131250000 {
> - opp-hz = /bits/ 64 <131250000>;
> - required-opps = <&rpmpd_opp_svs>;
> - };
> -
> - opp-210000000 {
> - opp-hz = /bits/ 64 <210000000>;
> - required-opps = <&rpmpd_opp_svs_plus>;
> - };
> -
> - opp-262500000 {
> - opp-hz = /bits/ 64 <262500000>;
> - required-opps = <&rpmpd_opp_nom>;
> - };
> - };
> -
> ports {
> #address-cells = <1>;
> #size-cells = <0>;

2023-04-07 23:38:08

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sdm630: move DSI opp-table out of DSI node

On Fri, 7 Apr 2023 21:26:05 +0200, Krzysztof Kozlowski wrote:
> The DSI OPP table on SDM630 is used by one DSI0, but on SDM660 is shared
> by two nodes (DSI0 and DSI1), thus it should be rather in top-level, not
> in DSI0.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sdm630: move DSI opp-table out of DSI node
commit: a9e76cf1146b4911b14c102f5237e28abbbccfef

Best regards,
--
Bjorn Andersson <[email protected]>