2023-04-06 15:15:23

by Tom Rix

Subject: [PATCH] drm/vc4: remove unused render_wait variable

smatch reports
drivers/gpu/drm/vc4/vc4_irq.c:60:1: warning: symbol
'render_wait' was not declared. Should it be static?

This variable is not used so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/gpu/drm/vc4/vc4_irq.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_irq.c b/drivers/gpu/drm/vc4/vc4_irq.c
index 1e6db0121ccd..563b3dfeb9b9 100644
--- a/drivers/gpu/drm/vc4/vc4_irq.c
+++ b/drivers/gpu/drm/vc4/vc4_irq.c
@@ -57,8 +57,6 @@
V3D_INT_FLDONE | \
V3D_INT_FRDONE)

-DECLARE_WAIT_QUEUE_HEAD(render_wait);
-
static void
vc4_overflow_mem_work(struct work_struct *work)
{
--
2.27.0

2023-04-11 12:36:51

by Maxime Ripard

Subject: Re: (subset) [PATCH] drm/vc4: remove unused render_wait variable

On Thu, 06 Apr 2023 11:12:03 -0400, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/vc4/vc4_irq.c:60:1: warning: symbol
> 'render_wait' was not declared. Should it be static?
>
> This variable is not used so remove it.
>
>
> [...]

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime