2023-04-12 15:33:48

by Vijaya Krishna Nivarthi

Subject: [V2 1/3] spi: dt-bindings: qcom,spi-qcom-qspi: Add iommus binding for qspi

Add iommus binding to documentation to be in sync with below
change to dtsi...
Add stream-id of qspi to iommus

Signed-off-by: Vijaya Krishna Nivarthi <[email protected]>
---
Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
index ee8f7ea..1696ac4 100644
--- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
+++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
@@ -29,6 +29,9 @@ properties:
reg:
maxItems: 1

+ iommus:
+ maxItems: 1
+
interrupts:
maxItems: 1

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by the Linux Foundation.

2023-04-12 16:03:39

by Krzysztof Kozlowski

Subject: Re: [V2 1/3] spi: dt-bindings: qcom,spi-qcom-qspi: Add iommus binding for qspi

On 12/04/2023 17:29, Vijaya Krishna Nivarthi wrote:
> Add iommus binding to documentation to be in sync with below
> change to dtsi...
> Add stream-id of qspi to iommus

This commit msg needs improvements. Try to avoid referring to other
patches in the series, unless necessary. In this case - it is not
necessary. You should provide here rationale for the binding change.

Subject: Drop redundant part "binding for qspi"

You also miss PATCH part. Use standard tools to generate patches, so
they will fit properly to Linux patch workflow.


Best regards,
Krzysztof